From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Dave Airlie <airlied@redhat.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/armada: Use drm_mode_get_hv_timing() to populate plane clip rectangle
Date: Mon, 5 Mar 2018 20:58:15 +0200 [thread overview]
Message-ID: <20180305185815.GU5453@intel.com> (raw)
In-Reply-To: <20180305084143.GB22212@phenom.ffwll.local>
On Mon, Mar 05, 2018 at 09:41:43AM +0100, Daniel Vetter wrote:
> On Tue, Jan 23, 2018 at 07:08:56PM +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Use drm_mode_get_hv_timing() to fill out the plane clip rectangle.
> >
> > Since armada isn't atomic we'll use crtc->enabled and crtc->mode instead
> > of the stuff under crtc_state.
> >
> > Once everyone agrees on how the clip rectangle gets set up we can
> > move the code into drm_atomic_helper_check_plane_state().
> >
> > Cc: Dave Airlie <airlied@redhat.com>
> > Cc: Russell King <rmk+kernel@armlinux.org.uk>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> For patches 3&4: Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> In case they do unexpectly break armada we can always just copypaste the
> previous version of the non-atomic helper into armada code to fix any
> regressions cropping up, so I don't see any big risks here. And I'd like
> to get this cleanup merged, just stumbled over it again.
>
> I pinged Dave Airlie on irc, and he's fine with that approach too.
>
> Acked-by: Dave Airlie <airlied@redhat.com>
>
> for the same two patches.
Cool. Thank you both.
Remainder of the series pushed to drm-misc-next.
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-03-05 18:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 17:08 [PATCH 1/5] drm/rcar-du: Use drm_mode_get_hv_timing() to populate plane clip rectangle Ville Syrjala
2018-01-23 17:08 ` [PATCH 2/5] drm/sun4i: " Ville Syrjala
2018-02-02 15:04 ` Ville Syrjälä
2018-01-23 17:08 ` [PATCH 3/5] drm/armada: Construct a temporary crtc state for plane checks Ville Syrjala
2018-01-23 18:42 ` Russell King - ARM Linux
2018-01-23 19:02 ` Ville Syrjälä
2018-02-02 14:10 ` Ville Syrjälä
2018-02-02 15:10 ` Ville Syrjälä
2018-02-23 15:55 ` Ville Syrjälä
2018-02-23 19:14 ` Russell King - ARM Linux
2018-01-23 17:08 ` [PATCH 4/5] drm/armada: Use drm_mode_get_hv_timing() to populate plane clip rectangle Ville Syrjala
2018-03-05 8:41 ` Daniel Vetter
2018-03-05 18:58 ` Ville Syrjälä [this message]
2018-01-23 17:08 ` [PATCH 5/5] drm: Don't pass clip to drm_atomic_helper_check_plane_state() Ville Syrjala
2018-01-23 17:08 ` Ville Syrjala
2018-01-23 17:08 ` Ville Syrjala
2018-01-23 17:46 ` Liviu Dudau
2018-01-23 17:46 ` Liviu Dudau
2018-01-23 17:46 ` Liviu Dudau
2018-01-23 18:06 ` Philipp Zabel
2018-01-23 18:06 ` Philipp Zabel
2018-01-23 18:06 ` Philipp Zabel
2018-01-24 0:12 ` Laurent Pinchart
2018-01-24 19:48 ` Sinclair Yeh
2018-01-24 19:48 ` Sinclair Yeh
2018-01-24 19:48 ` Sinclair Yeh
2018-01-26 5:23 ` Neil Armstrong
2018-01-26 5:23 ` Neil Armstrong
2018-01-26 5:23 ` Neil Armstrong
2018-02-05 6:50 ` Shawn Guo
2018-02-05 6:50 ` Shawn Guo
2018-02-05 6:50 ` Shawn Guo
2018-01-24 0:07 ` [PATCH 1/5] drm/rcar-du: Use drm_mode_get_hv_timing() to populate plane clip rectangle Laurent Pinchart
2018-01-24 15:01 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305185815.GU5453@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.