From: Eric Wong <e@80x24.org>
To: Andreas Heiduk <asheiduk@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] git-svn: allow empty email-address in authors-prog and authors-file
Date: Mon, 5 Mar 2018 20:20:17 +0000 [thread overview]
Message-ID: <20180305202017.GA26533@whir> (raw)
In-Reply-To: <CAFhHFBysKuDO9H4yJtnC6MJ+Jih5q4RsfwHTCsRXhXknapp4xg@mail.gmail.com>
Andreas Heiduk <asheiduk@gmail.com> wrote:
> 2018-03-05 2:42 GMT+01:00 Eric Sunshine <sunshine@sunshineco.com>:
> > Doesn't such a behavior change deserve being documented (and possibly tests)?
>
> The old behaviour was neither documented nor tested - the
> change did not break any test after all.
I consider that too low of a bar to justify a behavior change
which can negatively affect users.
next prev parent reply other threads:[~2018-03-05 20:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 11:22 [PATCH 1/2] git-svn: search --authors-prog in PATH too Andreas Heiduk
2018-03-04 11:22 ` [PATCH 2/2] git-svn: allow empty email-address in authors-prog and authors-file Andreas Heiduk
2018-03-05 1:42 ` Eric Sunshine
2018-03-05 9:37 ` Andreas Heiduk
2018-03-05 20:20 ` Eric Wong [this message]
2018-03-05 22:22 ` Eric Sunshine
2018-03-06 22:24 ` Andreas Heiduk
2018-03-05 0:52 ` [PATCH 1/2] git-svn: search --authors-prog in PATH too Eric Sunshine
2018-03-05 17:52 ` Eric Wong
2018-03-05 19:48 ` Andreas Heiduk
2018-03-05 20:16 ` Andreas Heiduk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305202017.GA26533@whir \
--to=e@80x24.org \
--cc=asheiduk@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.