From: Olaf Hering <olaf@aepfle.de>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
xen-devel@lists.xenproject.org, Jim Fehlig <jfehlig@suse.com>,
ian.jackson@eu.citrix.com
Subject: Re: [PATCH v2] tools/xenstore: try to get minimum thread stack size for watch thread
Date: Tue, 6 Mar 2018 12:24:07 +0100 [thread overview]
Message-ID: <20180306112407.GA12941@aepfle.de> (raw)
In-Reply-To: <20180302124024.ka6hdd4zrckuhqon@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1151 bytes --]
On Fri, Mar 02, Wei Liu wrote:
> But still, Juergen must have tested the change, so I wonder why it
> doesn't work in your setup. What is your build environment? Gcc version?
Unclear what the difference is between building in clean chroot and locally.
This change fixes it for me:
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -148,6 +148,9 @@ SHLIB_libxenguest = $(SHDEPS_libxenguest) -Wl,-rpath-link=$(XEN_LIBXC)
CFLAGS_libxenstore = -I$(XEN_XENSTORE)/include $(CFLAGS_xeninclude)
SHDEPS_libxenstore = $(SHLIB_libxentoolcore)
LDLIBS_libxenstore = $(SHDEPS_libxenstore) $(XEN_XENSTORE)/libxenstore$(libextension)
+ifeq ($(CONFIG_Linux),y)
+LDLIBS_libxenstore += -ldl
+endif
SHLIB_libxenstore = $(SHDEPS_libxenstore) -Wl,-rpath-link=$(XEN_XENSTORE)
CFLAGS_libxenstat = -I$(XEN_LIBXENSTAT)
--- a/tools/xenstore/Makefile
+++ b/tools/xenstore/Makefile
@@ -103,6 +103,7 @@ xs.opic: CFLAGS += -DUSE_PTHREAD
ifeq ($(CONFIG_Linux),y)
xs.opic: CFLAGS += -DUSE_DLSYM
libxenstore.so.$(MAJOR).$(MINOR): LDFLAGS += -ldl
+LDLIBS_xenstored += -ldl
endif
libxenstore.so.$(MAJOR).$(MINOR): xs.opic xs_lib.opic
Olaf
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-03-06 11:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 8:46 [PATCH v2] tools/xenstore: try to get minimum thread stack size for watch thread Juergen Gross
2018-02-26 9:46 ` Roger Pau Monné
2018-02-26 10:37 ` Wei Liu
2018-02-26 12:03 ` Ian Jackson
2018-02-26 12:04 ` Wei Liu
2018-02-26 12:12 ` Ian Jackson
2018-02-26 10:38 ` Wei Liu
2018-02-26 16:53 ` Jim Fehlig
2018-03-02 12:29 ` Wei Liu
2018-03-02 12:40 ` Wei Liu
2018-03-02 12:45 ` Juergen Gross
2018-03-02 14:28 ` Wei Liu
2018-03-02 14:54 ` Juergen Gross
2018-03-02 17:23 ` Jim Fehlig
2018-03-02 17:26 ` Wei Liu
2018-03-06 11:24 ` Olaf Hering [this message]
2018-03-06 12:40 ` Juergen Gross
2018-03-06 14:07 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306112407.GA12941@aepfle.de \
--to=olaf@aepfle.de \
--cc=ian.jackson@eu.citrix.com \
--cc=jfehlig@suse.com \
--cc=jgross@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.