From: Bin Liu <b-liu@ti.com>
To: Merlijn Wajer <merlijn@wizzup.org>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
linux-omap@vger.kernel.org
Subject: Re: usb: musb: "(null)" in sysfs mode file after disabling a gadget (and at other times, system hangs)
Date: Tue, 6 Mar 2018 08:36:59 -0600 [thread overview]
Message-ID: <20180306143659.GG14921@uda0271908> (raw)
In-Reply-To: <54fc4244-2584-f63d-23be-9e0413bcbee4@wizzup.org>
On Mon, Mar 05, 2018 at 08:44:40PM +0100, Merlijn Wajer wrote:
> Hi Bin,
>
> On 05/03/18 20:28, Bin Liu wrote:
>
> > The musb udc driver sets the state to b_idle without checking a
> > gadget driver, this should be cleaned up. I have add this in my backlog.
> > But if this issue doesn't bother you much right now, I will make the
> > action low priority and address it later whenever I got time. (likely
> > not very soon, I have a hand full of musb driver bugs to fix...)
>
> I can try to fix it this (or next) week. Do you have a pointer for me?
Quickly looking at the code, musb->xceiv->otg->state is set to OTG_STATE_B_IDLE
in musb_init_controller(), musb_gadget_setup(), musb_gadget_start(), and
musb_g_disconnect(). I am not sure if there is redundancy, and gadget
driver should be checked in some of them.
Regards,
-Bin.
prev parent reply other threads:[~2018-03-06 14:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 23:47 usb: musb: "(null)" in sysfs mode file after disabling a gadget (and at other times, system hangs) Merlijn Wajer
2018-03-02 15:27 ` Bin Liu
2018-03-02 16:47 ` Merlijn Wajer
2018-03-02 16:54 ` Pali Rohár
2018-03-05 19:28 ` Bin Liu
2018-03-05 19:28 ` Bin Liu
2018-03-05 19:44 ` Merlijn Wajer
2018-03-06 14:36 ` Bin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306143659.GG14921@uda0271908 \
--to=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.