From: Tony Lindgren <tony@atomide.com>
To: Tim Harvey <tharvey@gateworks.com>
Cc: linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Lee Jones <lee.jones@linaro.org>, Guo Zeng <Guo.Zeng@csr.com>
Subject: Re: [PATCH v2] regmap: irq: fix ack-invert
Date: Tue, 6 Mar 2018 06:57:49 -0800 [thread overview]
Message-ID: <20180306145749.GC5799@atomide.com> (raw)
In-Reply-To: <1520283457-31637-1-git-send-email-tharvey@gateworks.com>
Hi,
* Tim Harvey <tharvey@gateworks.com> [180305 20:59]:
> When acking irqs we need to take into account the ack-invert case.
> Without this chips that require 0's to ACK interrupts will never clear
> the interrupt.
>
> By using regmap_irq_update_bits to ACK the interrupts we use the masked
> status bits so we take care not to affect any other bits then use
> ack_invert to determine if we clear or set those bits.
This change to use regmap_irq_update_bits() now breaks things for
me with cpcap interrupts. So it seems to cause a non-inverted mode
regression. There should be no need to read the ack register, I
gues that's the whole idea of having a separate ack register :)
> The only user of ack_invert currently appears to be the motorola-cpcap
> driver which we find is incorrectly setting ack_invert and thus we
> fix that at the same time as otherwise it would break.
Regards,
Tony
next prev parent reply other threads:[~2018-03-06 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 20:57 [PATCH v2] regmap: irq: fix ack-invert Tim Harvey
2018-03-06 14:57 ` Tony Lindgren [this message]
2018-03-07 14:36 ` Mark Brown
2018-03-09 18:51 ` Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306145749.GC5799@atomide.com \
--to=tony@atomide.com \
--cc=Guo.Zeng@csr.com \
--cc=benjamin.gaignard@linaro.org \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.