All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	Adrian Hunter <adrian.hunter@intel.com>,
	Jiri Olsa <jolsa@redhat.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 8/9] perf auxtrace: Prevent decoding when --no-itrace
Date: Tue,  6 Mar 2018 14:23:42 -0300	[thread overview]
Message-ID: <20180306172343.16546-9-acme@kernel.org> (raw)
In-Reply-To: <20180306172343.16546-1-acme@kernel.org>

From: Adrian Hunter <adrian.hunter@intel.com>

Prevent auxtrace_queues__process_index() from queuing AUX area data for
decoding when the --no-itrace option has been used.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1520327598-1317-3-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/auxtrace.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
index 9faf3b5367db..6470ea2aa25e 100644
--- a/tools/perf/util/auxtrace.c
+++ b/tools/perf/util/auxtrace.c
@@ -60,6 +60,12 @@
 #include "sane_ctype.h"
 #include "symbol/kallsyms.h"
 
+static bool auxtrace__dont_decode(struct perf_session *session)
+{
+	return !session->itrace_synth_opts ||
+	       session->itrace_synth_opts->dont_decode;
+}
+
 int auxtrace_mmap__mmap(struct auxtrace_mmap *mm,
 			struct auxtrace_mmap_params *mp,
 			void *userpg, int fd)
@@ -762,6 +768,9 @@ int auxtrace_queues__process_index(struct auxtrace_queues *queues,
 	size_t i;
 	int err;
 
+	if (auxtrace__dont_decode(session))
+		return 0;
+
 	list_for_each_entry(auxtrace_index, &session->auxtrace_index, list) {
 		for (i = 0; i < auxtrace_index->nr; i++) {
 			ent = &auxtrace_index->entries[i];
@@ -892,12 +901,6 @@ int perf_event__synthesize_auxtrace_info(struct auxtrace_record *itr,
 	return err;
 }
 
-static bool auxtrace__dont_decode(struct perf_session *session)
-{
-	return !session->itrace_synth_opts ||
-	       session->itrace_synth_opts->dont_decode;
-}
-
 int perf_event__process_auxtrace_info(struct perf_tool *tool __maybe_unused,
 				      union perf_event *event,
 				      struct perf_session *session)
-- 
2.14.3

  parent reply	other threads:[~2018-03-06 17:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 17:23 [GIT PULL 0/9] perf/urgent fixes Arnaldo Carvalho de Melo
2018-03-06 17:23 ` Arnaldo Carvalho de Melo
2018-03-06 17:23 ` [PATCH 1/9] perf kallsyms: Fix the usage on the man page Arnaldo Carvalho de Melo
2018-03-06 17:23 ` [PATCH 2/9] perf top: Fix annoying fallback message on older kernels Arnaldo Carvalho de Melo
2018-03-06 17:23 ` [PATCH 3/9] perf annotate browser: Be more robust when drawing jump arrows Arnaldo Carvalho de Melo
2018-03-06 17:23 ` [PATCH 4/9] perf record: Fix crash in pipe mode Arnaldo Carvalho de Melo
2018-03-06 17:23 ` [PATCH 5/9] tools headers: Sync copy of kvm UAPI headers Arnaldo Carvalho de Melo
2018-03-06 17:23 ` [PATCH 6/9] tools headers: Sync x86's cpufeatures.h Arnaldo Carvalho de Melo
2018-03-06 17:23 ` [PATCH 7/9] perf stat: Fix CVS output format for non-supported counters Arnaldo Carvalho de Melo
2018-03-06 17:23 ` Arnaldo Carvalho de Melo [this message]
2018-03-06 17:23 ` [PATCH 9/9] perf tools: Fix trigger class trigger_on() Arnaldo Carvalho de Melo
2018-03-07  8:22 ` [GIT PULL 0/9] perf/urgent fixes Ingo Molnar
2018-03-07  8:22   ` Ingo Molnar
2018-03-07 14:23   ` Arnaldo Carvalho de Melo
2018-03-07 14:23     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180306172343.16546-9-acme@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.