From: Andi Kleen <ak@linux.intel.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@redhat.com>, Ilya Pronin <ipronin@twitter.com>
Subject: Re: [PATCH] perf stat: fix cvs output format
Date: Tue, 6 Mar 2018 09:53:20 -0800 [thread overview]
Message-ID: <20180306175320.GE25017@tassilo.jf.intel.com> (raw)
In-Reply-To: <CAM_iQpUfRMW4aGfaTdFqCRwuuLXFX69Aewg+k-aa6BMUKSrhTA@mail.gmail.com>
> Here is the output from your own commit:
>
> 423470,,stalled-cycles-frontend,509102,100.00,65.69,frontend cycles idle
> <not supported>,,stalled-cycles-backend,0,100.00,,,,
>
> so line 1 has 7 fields, line 2 has 9 fields, and this is expected?
If you had metrics on line 1 it would be correct.
So you just shifted it to break that case.
If you always want to have the same number of fields
you need to add two empty fields to the normal output
when there are no metrics.
-Andi
next prev parent reply other threads:[~2018-03-06 17:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 6:43 [PATCH] perf stat: fix cvs output format Cong Wang
2018-03-06 7:58 ` Jiri Olsa
2018-03-06 13:54 ` Arnaldo Carvalho de Melo
2018-03-06 17:00 ` Andi Kleen
2018-03-06 17:30 ` Arnaldo Carvalho de Melo
2018-03-06 18:57 ` Andi Kleen
2018-03-06 17:47 ` Cong Wang
2018-03-06 17:53 ` Andi Kleen [this message]
2018-03-06 19:03 ` Cong Wang
2018-03-06 20:31 ` Ilya Pronin
2018-03-07 17:04 ` Andi Kleen
2018-03-08 21:52 ` Ilya Pronin
2018-03-09 0:06 ` Andi Kleen
2018-03-07 8:27 ` [tip:perf/urgent] perf stat: Fix CVS output format for non-supported counters tip-bot for Ilya Pronin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306175320.GE25017@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@redhat.com \
--cc=ipronin@twitter.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.