From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lina Iyer Subject: Re: [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE Date: Tue, 6 Mar 2018 15:05:42 -0700 Message-ID: <20180306220542.GF4930@codeaurora.org> References: <20180302164317.10554-4-ilina@codeaurora.org> <201803061347.bjigZje9%fengguang.wu@intel.com> <20180306164704.3c33c046@vmware.local.home> <20180306215630.GE4930@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Content-Disposition: inline In-Reply-To: <20180306215630.GE4930@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Steven Rostedt Cc: kbuild test robot , kbuild-all@01.org, andy.gross@linaro.org, david.brown@linaro.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, rnayak@codeaurora.org, bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On Tue, Mar 06 2018 at 14:56 -0700, Lina Iyer wrote: >On Tue, Mar 06 2018 at 14:47 -0700, Steven Rostedt wrote: >>On Tue, 6 Mar 2018 13:38:06 +0800 >>kbuild test robot wrote: >> >>>>> drivers/soc/qcom/./trace-rpmh.h:29:3: error: implicit declaration of function '__assign_string'; did you mean '__assign_str'? [-Werror=implicit-function-declaration] >> >>Yes, you meant __assign_str(). I may have said __assign_string() in my >>comments, but I was doing it from memory, not actually compiling code. >> >>Please make sure you test the code and make sure it builds before >>posting. And displays the tracepoint as you expect it to. >> >I compiled and checked for sparse. Didn't explictly test for this. Not >sure why it did not fail for me. > Duh. FTRACE seems to have been disabled. Will fix and update. Thanks, Lina