From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, paulo.r.zanoni@intel.com
Subject: Re: [PATCH] drm/i915: Handle changing enable_fbc parameter at runtime better.
Date: Tue, 6 Mar 2018 14:58:33 -0800 [thread overview]
Message-ID: <20180306225833.GM15113@intel.com> (raw)
In-Reply-To: <f35ba75c-9310-1991-87e3-76583ec173af@linux.intel.com>
On Tue, Mar 06, 2018 at 09:12:02PM +0100, Maarten Lankhorst wrote:
> Op 06-03-18 om 21:02 schreef Rodrigo Vivi:
> > On Tue, Mar 06, 2018 at 11:22:16AM +0100, Maarten Lankhorst wrote:
> >> Op 05-03-18 om 19:50 schreef Rodrigo Vivi:
> >>> On Mon, Mar 05, 2018 at 01:36:08PM +0100, Maarten Lankhorst wrote:
> >>>> If i915.enable_fbc is cleared at runtime, but FBC was previously enabled
> >>>> then we don't disable FBC until the next time the crtc is disabled.
> >>>>
> >>>> Make sure that if the module param is changed, we disable FBC in
> >>>> intel_fbc_post_update so we never have to worry about disabling.
> >>> What about switching this from a parameter to debugfs toggle like drrs?
> >> There are still places where people recommend booting with i915.enable_fbc=0, this would break if we moved it to debugfs.
> > I think this was exactly what Chris and Joonas were trying to avoid when removing enable_rc6.
> > To avoid random recommendations of unvalidated combinations.
> >
> >> Having a small fix is enough.
> >>
> > Well... it would be fine for me.
> >
> > But I went to look the patch and I don't know what exactly we are trying to fix here.
> >
> > I don't know if it is safe to disable it like this when crtc is already enabled
> > and mostly: why?! why just not wait until next modeset?
> >
> > Cc: Paulo
> I'm trying to get rid of all modesets in kms_frontbuffer_tracking, they add up on glk where it's 50% of the total runtime for kms tests. :)
oh! this is a very good reason indeed. ;)
Patch looks correct to me. my only concern is with the reliability of toggling this on/off without
the modeset. But if there is problem with this I believe the test cases on CI will get this.
Besides I just remembered that I did some toggle on/off on sysfs at somepoint when playing with
that fbc false color and I never saw a problem... so:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> ~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-03-06 22:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 12:36 [PATCH] drm/i915: Handle changing enable_fbc parameter at runtime better Maarten Lankhorst
2018-03-05 13:18 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-05 16:35 ` ✓ Fi.CI.IGT: " Patchwork
2018-03-05 18:50 ` [PATCH] " Rodrigo Vivi
2018-03-06 10:22 ` Maarten Lankhorst
2018-03-06 20:02 ` Rodrigo Vivi
2018-03-06 20:12 ` Maarten Lankhorst
2018-03-06 22:58 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306225833.GM15113@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.