From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [media] cpia2_usb: drop bogus interface-release call From: Johan Hovold Message-Id: <20180307094936.9140-1-johan@kernel.org> Date: Wed, 7 Mar 2018 10:49:36 +0100 To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-usb@vger.kernel.org, Johan Hovold List-ID: RHJvcCBib2d1cyBjYWxsIHRvIHVzYl9kcml2ZXJfcmVsZWFzZV9pbnRlcmZhY2UoKSBmcm9tIHRo ZSBkaXNjb25uZWN0KCkKY2FsbGJhY2suIEFzIHRoZSBpbnRlcmZhY2UgaXMgYWxyZWFkeSBiZWlu ZyB1bmJvdW5kIGF0IHRoaXMgcG9pbnQsCnVzYl9kcml2ZXJfcmVsZWFzZV9pbnRlcmZhY2UoKSBz aW1wbHkgcmV0dXJucyBlYXJseS4KClNpZ25lZC1vZmYtYnk6IEpvaGFuIEhvdm9sZCA8am9oYW5A a2VybmVsLm9yZz4KLS0tCiBkcml2ZXJzL21lZGlhL3VzYi9jcGlhMi9jcGlhMl91c2IuYyB8IDMg LS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJz L21lZGlhL3VzYi9jcGlhMi9jcGlhMl91c2IuYyBiL2RyaXZlcnMvbWVkaWEvdXNiL2NwaWEyL2Nw aWEyX3VzYi5jCmluZGV4IGYzYTFlNWIxZTU3Yy4uYjUxZmMzNzJjYTI1IDEwMDY0NAotLS0gYS9k cml2ZXJzL21lZGlhL3VzYi9jcGlhMi9jcGlhMl91c2IuYworKysgYi9kcml2ZXJzL21lZGlhL3Vz Yi9jcGlhMi9jcGlhMl91c2IuYwpAQCAtOTEwLDkgKzkxMCw2IEBAIHN0YXRpYyB2b2lkIGNwaWEy X3VzYl9kaXNjb25uZWN0KHN0cnVjdCB1c2JfaW50ZXJmYWNlICppbnRmKQogCQl3YWtlX3VwX2lu dGVycnVwdGlibGUoJmNhbS0+d3Ffc3RyZWFtKTsKIAl9CiAKLQlEQkcoIlJlbGVhc2luZyBpbnRl cmZhY2VcbiIpOwotCXVzYl9kcml2ZXJfcmVsZWFzZV9pbnRlcmZhY2UoJmNwaWEyX2RyaXZlciwg aW50Zik7Ci0KIAlMT0coIkNQaUEyIGNhbWVyYSBkaXNjb25uZWN0ZWQuXG4iKTsKIH0KIAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lf0-f67.google.com ([209.85.215.67]:36410 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754070AbeCGJt4 (ORCPT ); Wed, 7 Mar 2018 04:49:56 -0500 From: Johan Hovold To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-usb@vger.kernel.org, Johan Hovold Subject: [PATCH] [media] cpia2_usb: drop bogus interface-release call Date: Wed, 7 Mar 2018 10:49:36 +0100 Message-Id: <20180307094936.9140-1-johan@kernel.org> Sender: linux-media-owner@vger.kernel.org List-ID: Drop bogus call to usb_driver_release_interface() from the disconnect() callback. As the interface is already being unbound at this point, usb_driver_release_interface() simply returns early. Signed-off-by: Johan Hovold --- drivers/media/usb/cpia2/cpia2_usb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/usb/cpia2/cpia2_usb.c b/drivers/media/usb/cpia2/cpia2_usb.c index f3a1e5b1e57c..b51fc372ca25 100644 --- a/drivers/media/usb/cpia2/cpia2_usb.c +++ b/drivers/media/usb/cpia2/cpia2_usb.c @@ -910,9 +910,6 @@ static void cpia2_usb_disconnect(struct usb_interface *intf) wake_up_interruptible(&cam->wq_stream); } - DBG("Releasing interface\n"); - usb_driver_release_interface(&cpia2_driver, intf); - LOG("CPiA2 camera disconnected.\n"); } -- 2.16.2