From mboxrd@z Thu Jan 1 00:00:00 1970 From: keith.busch@intel.com (Keith Busch) Date: Wed, 7 Mar 2018 08:03:45 -0700 Subject: [PATCH] Revert "nvme: create 'slaves' and 'holders' entries for hidden controllers" In-Reply-To: <1c1332d4-1d92-af8f-974c-2eafcde741f2@suse.de> References: <20180307131358.20275-1-hch@lst.de> <1c1332d4-1d92-af8f-974c-2eafcde741f2@suse.de> Message-ID: <20180307150344.GE30975@localhost.localdomain> On Wed, Mar 07, 2018@02:40:39PM +0100, Hannes Reinecke wrote: > The nice thing about the holders/slave is that one can discover the > topology, and potentially figure out any issues (like one path going > down etc). I also thought the sysfs hierarchy was useful, but it sounds like causes more problems than it solves. :( > How do we detect the topology now? > Does nvme cli has the functionality? Not in the way you'd probably like. It can provide all the information you'd need to put it together, but it doesn't provide a convenient method to get or visualize it. I'll add a note on the project to fix that. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com ([134.134.136.65]:14348 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754582AbeCGPDm (ORCPT ); Wed, 7 Mar 2018 10:03:42 -0500 Date: Wed, 7 Mar 2018 08:03:45 -0700 From: Keith Busch To: Hannes Reinecke Cc: Christoph Hellwig , linux-nvme@lists.infradead.org, axboe@kernel.dk, sagi@grimberg.me, bharat@chelsio.com, sitsofe@gmail.com, kzak@redhat.com, stable@vger.kernel.org Subject: Re: [PATCH] Revert "nvme: create 'slaves' and 'holders' entries for hidden controllers" Message-ID: <20180307150344.GE30975@localhost.localdomain> References: <20180307131358.20275-1-hch@lst.de> <1c1332d4-1d92-af8f-974c-2eafcde741f2@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1c1332d4-1d92-af8f-974c-2eafcde741f2@suse.de> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Mar 07, 2018 at 02:40:39PM +0100, Hannes Reinecke wrote: > The nice thing about the holders/slave is that one can discover the > topology, and potentially figure out any issues (like one path going > down etc). I also thought the sysfs hierarchy was useful, but it sounds like causes more problems than it solves. :( > How do we detect the topology now? > Does nvme cli has the functionality? Not in the way you'd probably like. It can provide all the information you'd need to put it together, but it doesn't provide a convenient method to get or visualize it. I'll add a note on the project to fix that.