From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v3.18] net: fec: introduce fec_ptp_stop and use in probe fail path Date: Wed, 7 Mar 2018 09:23:48 -0800 Message-ID: <20180307172348.GD7097@kroah.com> References: <1520378603-4792-1-git-send-email-linux@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S . Miller" , netdev@vger.kernel.org, stable@vger.kernel.org, Lucas Stach To: Guenter Roeck Return-path: Content-Disposition: inline In-Reply-To: <1520378603-4792-1-git-send-email-linux@roeck-us.net> Sender: stable-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, Mar 06, 2018 at 03:23:23PM -0800, Guenter Roeck wrote: > From: Lucas Stach > > [ upstream commit 32cba57ba74be58589aeb4cb6496183e46a5e3e5 ] > > This function frees resources and cancels delayed work item that > have been initialized in fec_ptp_init(). > > Use this to do proper error handling if something goes wrong in > probe function after fec_ptp_init has been called. > > Signed-off-by: Lucas Stach > Acked-by: Fugang Duan > Signed-off-by: David S. Miller > [groeck: backport: context changes in .../fec_main.c] > Signed-off-by: Guenter Roeck > --- > Not really sure if I should send this one to David or Greg, since v3.18 is no > longer officially supported, so I am sending it to both. Sorry for the noise. > > This patch fixes a crash seen when running sabrelite images in a version > of qemu which fixes https://bugs.launchpad.net/qemu/+bug/1753309. This works for me, now queued up, thanks. greg k-h