From: Jonathan Cameron <jic23@kernel.org>
To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
daniel.baluta@nxp.com, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] staging:iio:meter: Aligns open parenthesis
Date: Wed, 7 Mar 2018 20:12:15 +0000 [thread overview]
Message-ID: <20180307201215.1fe587d3@archlinux> (raw)
In-Reply-To: <e276c37521ce2520df734dff1a70663d2f4c0d9b.1520382753.git.rodrigosiqueiramelo@gmail.com>
On Tue, 6 Mar 2018 21:44:26 -0300
Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> wrote:
> This patch fixes the checkpatch.pl checks:
>
> staging/iio/meter/ade7854-spi.c:19: CHECK: Alignment should match open
> parenthesis
> staging/iio/meter/ade7854-spi.c:44: CHECK: Alignment should match open
> parenthesis
> staging/iio/meter/ade7854-spi.c:70: CHECK: Alignment should match open
> parenthesis
> staging/iio/meter/ade7854-spi.c:97: CHECK: Alignment should match open
> parenthesis
> staging/iio/meter/ade7854-spi.c:125: CHECK: Alignment should match open
> parenthesis
>
> ...
>
> Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/staging/iio/meter/ade7758_trigger.c | 6 ++---
> drivers/staging/iio/meter/ade7854-spi.c | 40 ++++++++++++++---------------
> 2 files changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/staging/iio/meter/ade7758_trigger.c b/drivers/staging/iio/meter/ade7758_trigger.c
> index 1f0d1a0cf889..3314aa298d99 100644
> --- a/drivers/staging/iio/meter/ade7758_trigger.c
> +++ b/drivers/staging/iio/meter/ade7758_trigger.c
> @@ -30,7 +30,7 @@ static irqreturn_t ade7758_data_rdy_trig_poll(int irq, void *private)
> * ade7758_data_rdy_trigger_set_state() set datardy interrupt state
> **/
> static int ade7758_data_rdy_trigger_set_state(struct iio_trigger *trig,
> - bool state)
> + bool state)
> {
> struct iio_dev *indio_dev = iio_trigger_get_drvdata(trig);
>
> @@ -63,8 +63,8 @@ int ade7758_probe_trigger(struct iio_dev *indio_dev)
> int ret;
>
> st->trig = iio_trigger_alloc("%s-dev%d",
> - spi_get_device_id(st->us)->name,
> - indio_dev->id);
> + spi_get_device_id(st->us)->name,
> + indio_dev->id);
> if (!st->trig) {
> ret = -ENOMEM;
> goto error_ret;
> diff --git a/drivers/staging/iio/meter/ade7854-spi.c b/drivers/staging/iio/meter/ade7854-spi.c
> index 72eddfec21f7..4419b8f06197 100644
> --- a/drivers/staging/iio/meter/ade7854-spi.c
> +++ b/drivers/staging/iio/meter/ade7854-spi.c
> @@ -16,8 +16,8 @@
> #include "ade7854.h"
>
> static int ade7854_spi_write_reg_8(struct device *dev,
> - u16 reg_address,
> - u8 val)
> + u16 reg_address,
> + u8 val)
> {
> int ret;
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> @@ -41,8 +41,8 @@ static int ade7854_spi_write_reg_8(struct device *dev,
> }
>
> static int ade7854_spi_write_reg_16(struct device *dev,
> - u16 reg_address,
> - u16 val)
> + u16 reg_address,
> + u16 val)
> {
> int ret;
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> @@ -67,8 +67,8 @@ static int ade7854_spi_write_reg_16(struct device *dev,
> }
>
> static int ade7854_spi_write_reg_24(struct device *dev,
> - u16 reg_address,
> - u32 val)
> + u16 reg_address,
> + u32 val)
> {
> int ret;
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> @@ -94,8 +94,8 @@ static int ade7854_spi_write_reg_24(struct device *dev,
> }
>
> static int ade7854_spi_write_reg_32(struct device *dev,
> - u16 reg_address,
> - u32 val)
> + u16 reg_address,
> + u32 val)
> {
> int ret;
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> @@ -122,8 +122,8 @@ static int ade7854_spi_write_reg_32(struct device *dev,
> }
>
> static int ade7854_spi_read_reg_8(struct device *dev,
> - u16 reg_address,
> - u8 *val)
> + u16 reg_address,
> + u8 *val)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7854_state *st = iio_priv(indio_dev);
> @@ -149,7 +149,7 @@ static int ade7854_spi_read_reg_8(struct device *dev,
> ret = spi_sync_transfer(st->spi, xfers, ARRAY_SIZE(xfers));
> if (ret) {
> dev_err(&st->spi->dev, "problem when reading 8 bit register 0x%02X",
> - reg_address);
> + reg_address);
> goto error_ret;
> }
> *val = st->rx[0];
> @@ -160,8 +160,8 @@ static int ade7854_spi_read_reg_8(struct device *dev,
> }
>
> static int ade7854_spi_read_reg_16(struct device *dev,
> - u16 reg_address,
> - u16 *val)
> + u16 reg_address,
> + u16 *val)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7854_state *st = iio_priv(indio_dev);
> @@ -186,7 +186,7 @@ static int ade7854_spi_read_reg_16(struct device *dev,
> ret = spi_sync_transfer(st->spi, xfers, ARRAY_SIZE(xfers));
> if (ret) {
> dev_err(&st->spi->dev, "problem when reading 16 bit register 0x%02X",
> - reg_address);
> + reg_address);
> goto error_ret;
> }
> *val = be16_to_cpup((const __be16 *)st->rx);
> @@ -197,8 +197,8 @@ static int ade7854_spi_read_reg_16(struct device *dev,
> }
>
> static int ade7854_spi_read_reg_24(struct device *dev,
> - u16 reg_address,
> - u32 *val)
> + u16 reg_address,
> + u32 *val)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7854_state *st = iio_priv(indio_dev);
> @@ -224,7 +224,7 @@ static int ade7854_spi_read_reg_24(struct device *dev,
> ret = spi_sync_transfer(st->spi, xfers, ARRAY_SIZE(xfers));
> if (ret) {
> dev_err(&st->spi->dev, "problem when reading 24 bit register 0x%02X",
> - reg_address);
> + reg_address);
> goto error_ret;
> }
> *val = (st->rx[0] << 16) | (st->rx[1] << 8) | st->rx[2];
> @@ -235,8 +235,8 @@ static int ade7854_spi_read_reg_24(struct device *dev,
> }
>
> static int ade7854_spi_read_reg_32(struct device *dev,
> - u16 reg_address,
> - u32 *val)
> + u16 reg_address,
> + u32 *val)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7854_state *st = iio_priv(indio_dev);
> @@ -262,7 +262,7 @@ static int ade7854_spi_read_reg_32(struct device *dev,
> ret = spi_sync_transfer(st->spi, xfers, ARRAY_SIZE(xfers));
> if (ret) {
> dev_err(&st->spi->dev, "problem when reading 32 bit register 0x%02X",
> - reg_address);
> + reg_address);
> goto error_ret;
> }
> *val = be32_to_cpup((const __be32 *)st->rx);
prev parent reply other threads:[~2018-03-07 20:12 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 0:43 [PATCH v2 0/3] staging:iio:meter: Checkpatch cleanup for meter Rodrigo Siqueira
2018-03-07 0:43 ` Rodrigo Siqueira
2018-03-07 0:43 ` [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR Rodrigo Siqueira
2018-03-07 0:43 ` Rodrigo Siqueira
2018-03-07 20:07 ` Jonathan Cameron
2018-03-07 20:07 ` Jonathan Cameron
2018-03-09 0:37 ` Rodrigo Siqueira
2018-03-09 0:37 ` Rodrigo Siqueira
2018-03-10 15:10 ` Jonathan Cameron
2018-03-15 6:10 ` John Syne
2018-03-15 6:12 ` John Syne
2018-03-15 6:12 ` John Syne
2018-03-17 20:30 ` Jonathan Cameron
2018-03-17 20:30 ` Jonathan Cameron
2018-03-18 6:11 ` John Syne
2018-03-18 6:11 ` John Syne
2018-03-18 12:23 ` meter ABI: (was Re: [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR) Jonathan Cameron
2018-03-20 5:57 ` John Syne
2018-03-20 5:57 ` John Syne
2018-03-24 15:02 ` Jonathan Cameron
2018-03-24 15:02 ` Jonathan Cameron
2018-03-24 22:45 ` John Syne
2018-03-24 22:45 ` John Syne
2018-03-25 16:29 ` Jonathan Cameron
2018-03-25 16:29 ` Jonathan Cameron
2018-03-25 20:36 ` John Syne
2018-03-25 20:36 ` John Syne
2018-03-30 9:13 ` Jonathan Cameron
2018-03-30 9:13 ` Jonathan Cameron
2018-03-20 6:28 ` John Syne
2018-03-20 6:28 ` John Syne
2018-03-24 15:18 ` Jonathan Cameron
2018-03-24 15:18 ` Jonathan Cameron
2018-03-24 23:06 ` John Syne
2018-03-25 16:44 ` Jonathan Cameron
2018-03-25 16:44 ` Jonathan Cameron
2018-03-25 20:43 ` John Syne
2018-03-25 20:44 ` John Syne
2018-03-25 20:44 ` John Syne
2018-03-24 23:18 ` John Syne
2018-03-25 7:10 ` John Syne
2018-03-25 7:10 ` John Syne
2018-03-25 7:13 ` John Syne
2018-03-25 7:13 ` John Syne
2018-03-25 8:26 ` John Syne
2018-03-25 8:29 ` John Syne
2018-03-25 8:29 ` John Syne
2018-03-25 16:54 ` Jonathan Cameron
2018-03-25 16:54 ` Jonathan Cameron
2018-03-25 20:53 ` John Syne
2018-03-25 20:53 ` John Syne
2018-03-30 9:16 ` Jonathan Cameron
2018-03-07 0:44 ` [PATCH v2 2/3] staging:iio:meter: Remove unused macro IIO_DEV_ATTR_CH_OFF Rodrigo Siqueira
2018-03-07 0:44 ` Rodrigo Siqueira
2018-03-07 20:09 ` Jonathan Cameron
2018-03-07 20:09 ` Jonathan Cameron
2018-03-07 0:44 ` [PATCH v2 3/3] staging:iio:meter: Aligns open parenthesis Rodrigo Siqueira
2018-03-07 0:44 ` Rodrigo Siqueira
2018-03-07 20:12 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307201215.1fe587d3@archlinux \
--to=jic23@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.