From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1282308-1520493115-2-5487362232625911105 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='CN', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1520493114; b=omS1yog0FEaIa6cMImomsiK5tg8SWzfU3hjX4Jl5YU13wMM S/Me1XoB4mpZcRNp4aaOoE+CLMCiy5Mx6dhTlxFrkDIYsQSICK1Xvv3spFWzOxGK Y/UIpafdJ3dg0bHC2+PdV4janPoy1uJe6ihKwWstpXL8JfGmOF6EKbcnVA7Nd21z +ncGJB7AxZK8gjlx56gjJjxlw8nSOM5yG+/qhI4JrlJza9OyiFQoGAtoiCPZ/VO4 Z3PZi8+LiF1eVWVGszmy3pbwt6lpCLAzqgKg0Jw8ozfO+MAKiYZ3cVJWGaXZN1am vr69d53Vn7Uhe5OmyGOo/hz2DE94DuhCFbgi+eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1520493114; bh=Xg1KLr 5OyWEEc91VszOho2HMh+PD41WbFQ4LvE0L1cE=; b=rk5OZMMbeetZGiBaYabvKc 1tvnAuNrllMHFhOeCoRrVXGs2OSSI+GfDP4La4bo80ay/8sVwSh3e9XSLRNtenke 9H3d09KLVb1OWc7rvN4pSrqyog/GA0IrhzupZntrRARTuL5T5SBoaCgPBJpKjgSr LIOYPmM7Nr70+sGOoknF8aV2HsIxiL1rCZ9JWXjHIuptUb2+4CaMV2S8/eh/j4Gy a4IiuVCBDTmyuu70R/d6tNnBtCj/rKct9NBVb4uYJADNtwUGk1knWLkM5TggRHJB yA2wHizlAn3bj53EtHmbNf2pPtcWAFu5Ee0ycBh+qn6G46mGpg0jYSDJ+1oYwgyg == ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=Sq7nj8EI x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=Sq7nj8EI x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934717AbeCHHLh (ORCPT ); Thu, 8 Mar 2018 02:11:37 -0500 Received: from mail-by2nam03on0095.outbound.protection.outlook.com ([104.47.42.95]:43489 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755030AbeCHE4I (ORCPT ); Wed, 7 Mar 2018 23:56:08 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: "Gustavo A. R. Silva" , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH AUTOSEL for 4.15 07/78] media: c8sectpfe: fix potential NULL pointer dereference in c8sectpfe_timer_interrupt Thread-Topic: [PATCH AUTOSEL for 4.15 07/78] media: c8sectpfe: fix potential NULL pointer dereference in c8sectpfe_timer_interrupt Thread-Index: AQHTtpnCp1+3rKi56U++/Z5uivFjnQ== Date: Thu, 8 Mar 2018 04:56:03 +0000 Message-ID: <20180308045525.7662-7-alexander.levin@microsoft.com> References: <20180308045525.7662-1-alexander.levin@microsoft.com> In-Reply-To: <20180308045525.7662-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB0902;7:T/Gqv6+LGWtPHrIepRVljEFHR58/oNP5MYom2KpHF13qPRS1s5FZjc8VvwLYYvEgWLCLsg7Ygcvz2y2shBaNr9j2Lnm0rwBSJwfszm+/w6EsYasYNPKDInHny8prC9WDb/uBdi0MquEVVKVUuRx8ZERnX824nki6OtCU+jcYOVJ5MjQ9GYAShdbWKkPwVfRm7uI2kiGJf20aFbRBD1m7dcWusm/GCAwWHFg/W1SoYhK27NG1xFL70H4C8Wwbu642;20:569pd0v1Wobv2HR2FgB5jYAoWHQMz+ovGh991IOTFRckhHDYqAw7KEgs1yiA61YnKJ37dPVFaqa6KiH42Cqtoa2DN0d3QqtvW119+Ggxm7cwLtih337iyei/S5ZnvlSCZCb+v/ku7wibde823JlANsFII2TJCXZjsQHugXa8PX4= x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9f8bfe3d-f6f6-49a1-4485-08d584b0e550 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020);SRVR:DM5PR2101MB0902; x-ms-traffictypediagnostic: DM5PR2101MB0902: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040501)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231220)(944501244)(52105095)(93006095)(93001095)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011);SRVR:DM5PR2101MB0902;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB0902; x-forefront-prvs: 060503E79B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(39860400002)(39380400002)(376002)(366004)(396003)(189003)(199004)(8936002)(81156014)(81166006)(7736002)(5250100002)(8676002)(99286004)(26005)(107886003)(186003)(2950100002)(15760500003)(106356001)(10090500001)(575784001)(305945005)(66066001)(97736004)(2501003)(86362001)(3846002)(3660700001)(72206003)(6436002)(1076002)(6486002)(5660300001)(54906003)(110136005)(68736007)(53936002)(14454004)(36756003)(25786009)(478600001)(10290500003)(6506007)(59450400001)(2900100001)(102836004)(76176011)(6512007)(22452003)(6116002)(316002)(4326008)(105586002)(86612001)(2906002)(3280700002)(22906009)(32563001)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB0902;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: XKRAtdnlAa4vLpaN9BRdqGf5W4KeS5jqx/tYt0ddEofvwbpsak8ZjSABQSpQKlS9rnDLYInEp8WkvORfovgbl9nkuIyEVZlH81+nwunYVTj5E7kTz0+tY2VaEGac9Kxww7YTdY6+1jgPeWT6bEWJoALsyAQd6vbZxlxkf9u7g6kZ+kC0PpS+P91p1BG+5zi6qOrcyyoiJoDTohvIJxmSEocAm5KusGwf1sfeFD2/QR1eH2AJwqW9pBI8C6/201yd2a4n9jK2z13mSwByvJXC+Hq8FOh1MIvyQK1LM2nUQKLRMf/6f+BfHxjK1/sg3ZjmrDmXdDNwj+2f1J9rlyxGqA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f8bfe3d-f6f6-49a1-4485-08d584b0e550 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2018 04:56:03.6124 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0902 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: "Gustavo A. R. Silva" [ Upstream commit baed3c4bc4c13de93e0dba0a26d601411ebcb389 ] _channel_ is being dereferenced before it is null checked, hence there is a potential null pointer dereference. Fix this by moving the pointer derefere= nce after _channel_ has been null checked. This issue was detected with the help of Coccinelle. Fixes: c5f5d0f99794 ("[media] c8sectpfe: STiH407/10 Linux DVB demux support= ") Signed-off-by: Gustavo A. R. Silva Acked-by: Patrice Chotard Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/driver= s/media/platform/sti/c8sectpfe/c8sectpfe-core.c index a0acee7671b1..8bd19e61846d 100644 --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c @@ -83,7 +83,7 @@ static void c8sectpfe_timer_interrupt(struct timer_list *= t) static void channel_swdemux_tsklet(unsigned long data) { struct channel_info *channel =3D (struct channel_info *)data; - struct c8sectpfei *fei =3D channel->fei; + struct c8sectpfei *fei; unsigned long wp, rp; int pos, num_packets, n, size; u8 *buf; @@ -91,6 +91,8 @@ static void channel_swdemux_tsklet(unsigned long data) if (unlikely(!channel || !channel->irec)) return; =20 + fei =3D channel->fei; + wp =3D readl(channel->irec + DMA_PRDS_BUSWP_TP(0)); rp =3D readl(channel->irec + DMA_PRDS_BUSRP_TP(0)); =20 --=20 2.14.1