From: James Hogan <jhogan@kernel.org>
To: Frank Rowand <frowand.list@gmail.com>
Cc: linux-kbuild@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Ralf Baechle <ralf@linux-mips.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Kevin Cernekee <cernekee@gmail.com>,
linux-mips@linux-mips.org, stable@vger.kernel.org
Subject: Re: [PATCH] kbuild: Handle builtin dtb files containing hyphens
Date: Thu, 8 Mar 2018 07:09:48 +0000 [thread overview]
Message-ID: <20180308070948.GA5187@saruman> (raw)
In-Reply-To: <a6c448df-c026-dafe-6d34-801f69ca64fe@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]
On Wed, Mar 07, 2018 at 03:19:11PM -0800, Frank Rowand wrote:
> On 03/07/18 12:25, James Hogan wrote:
> > On Wed, Mar 07, 2018 at 12:11:41PM -0800, Frank Rowand wrote:
> >> On 03/07/18 06:06, James Hogan wrote:
> >>> Quite a lot of dts files have hyphens, but its only a problem on MIPS
> >>> where such files can be built into the kernel. For example when
> >>> CONFIG_DT_NETGEAR_CVG834G=y, or on BMIPS kernels when the dtbs target is
> >>> used (in the latter case it admitedly shouldn't really build all the
> >>> dtb.o files, but thats a separate issue).
> > I'll keep the paragraph about MIPS and the example configuration though,
> > as I think its important information to reproduce the problem, and to
> > justify why it wouldn't be appropriate to just rename the files (which
> > was my first reaction).
>
> Other than the part that says "its only a problem on MIPS". That is
> pedantically correct because no other architecture (that I am aware
> of, not that I searched) currently has a devicetree source file name
> with a hyphen in it, where that file is compiled into the kernel as
> an asm file. But it is potentially a problem on any architecture
> to it is misleading to label it as MIPS only.
Okay I'll reword to make it clearer and do a v2.
Thanks
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-08 7:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 14:06 [PATCH] kbuild: Handle builtin dtb files containing hyphens James Hogan
2018-03-07 20:11 ` Frank Rowand
2018-03-07 20:25 ` James Hogan
2018-03-07 23:19 ` Frank Rowand
2018-03-08 7:09 ` James Hogan [this message]
2018-03-08 8:41 ` Masahiro Yamada
2018-03-08 11:02 ` [PATCH v2] kbuild: Handle builtin dtb file names " James Hogan
2018-03-08 16:25 ` Masahiro Yamada
2018-03-08 6:56 ` [PATCH] kbuild: Handle builtin dtb files " Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308070948.GA5187@saruman \
--to=jhogan@kernel.org \
--cc=cernekee@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=michal.lkml@markovi.net \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.