All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, Laurent Vivier <lvivier@redhat.com>,
	Fam Zheng <famz@redhat.com>, Juan Quintela <quintela@redhat.com>,
	mdroth@linux.vnet.ibm.com, Markus Armbruster <armbru@redhat.com>,
	marcandre.lureau@redhat.com,
	Stefan Hajnoczi <shajnocz@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 17/23] qapi: introduce new cmd option "allow-oob"
Date: Thu, 8 Mar 2018 19:51:49 +0800	[thread overview]
Message-ID: <20180308115149.GG32252@xz-mi> (raw)
In-Reply-To: <20180308110413.044b15ed@redhat.com>

On Thu, Mar 08, 2018 at 11:04:13AM +0100, Igor Mammedov wrote:

[...]

> > diff --git a/include/qapi/qmp/dispatch.h b/include/qapi/qmp/dispatch.h
> > index 20578dcd48..b76798800c 100644
> > --- a/include/qapi/qmp/dispatch.h
> > +++ b/include/qapi/qmp/dispatch.h
> > @@ -23,6 +23,7 @@ typedef enum QmpCommandOptions
> >  {
> >      QCO_NO_OPTIONS = 0x0,
> >      QCO_NO_SUCCESS_RESP = 0x1,
> > +    QCO_ALLOW_OOB = 0x2,
> Options are essentially bitmask,
> so using shift for value would be more explicit way to express it.
> 
>   QCO_ALLOW_OOB = (1U << 1)

I'll squash the change into the patch:

diff --git a/include/qapi/qmp/dispatch.h b/include/qapi/qmp/dispatch.h         
index b4cb25888f..26eb13ff41 100644                   
--- a/include/qapi/qmp/dispatch.h      
+++ b/include/qapi/qmp/dispatch.h      
@@ -20,9 +20,9 @@ typedef void (QmpCommandFunc)(QDict *, QObject **, Error **);
                                                                               
 typedef enum QmpCommandOptions        
 {                                                                             
-    QCO_NO_OPTIONS = 0x0,                                                     
-    QCO_NO_SUCCESS_RESP = 0x1,        
-    QCO_ALLOW_OOB = 0x2,                                                      
+    QCO_NO_OPTIONS            =  0x0,                                         
+    QCO_NO_SUCCESS_RESP       =  (1U << 0),                                   
+    QCO_ALLOW_OOB             =  (1U << 1),                                   
 } QmpCommandOptions;                                        
                                           
 typedef struct QmpCommand                                                     

Since the change is trivial, I'll keep r-bs for Stefan and Fam.
Anyone who thinks I shouldn't please shoot.  Thanks,

-- 
Peter Xu

  parent reply	other threads:[~2018-03-08 11:52 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24  5:39 [Qemu-devel] [PATCH v7 00/23] QMP: out-of-band (OOB) execution support Peter Xu
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 01/23] docs: update QMP documents for OOB commands Peter Xu
2018-02-09 14:10   ` Eric Blake
2018-02-11  5:34     ` Peter Xu
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 02/23] qobject: introduce qstring_get_try_str() Peter Xu
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 03/23] qobject: introduce qobject_get_try_str() Peter Xu
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 04/23] qobject: let object_property_get_str() use new API Peter Xu
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 05/23] monitor: move skip_flush into monitor_data_init Peter Xu
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 06/23] monitor: move the cur_mon hack deeper for QMP Peter Xu
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 07/23] monitor: unify global init Peter Xu
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 08/23] monitor: let mon_list be tail queue Peter Xu
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 09/23] monitor: allow using IO thread for parsing Peter Xu
2018-02-21 16:00   ` Stefan Hajnoczi
2018-02-22 10:01     ` Peter Xu
2018-02-22 15:41       ` Stefan Hajnoczi
2018-02-22 15:50       ` Daniel P. Berrangé
2018-02-23  2:56         ` Peter Xu
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 10/23] qmp: introduce QMPCapability Peter Xu
2018-02-21 16:17   ` Stefan Hajnoczi
2018-02-22 10:42     ` Peter Xu
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 11/23] monitor: introduce monitor_qmp_respond() Peter Xu
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 12/23] monitor: let suspend_cnt be thread safe Peter Xu
2018-02-21 16:44   ` Stefan Hajnoczi
2018-02-21 16:45   ` Stefan Hajnoczi
2018-02-21 16:45   ` Stefan Hajnoczi
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 13/23] monitor: let suspend/resume work even with QMPs Peter Xu
2018-02-21 16:50   ` Stefan Hajnoczi
2018-02-22 10:49     ` Peter Xu
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 14/23] monitor: separate QMP parser and dispatcher Peter Xu
2018-02-21 17:17   ` Stefan Hajnoczi
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 15/23] qmp: add new event "command-dropped" Peter Xu
2018-02-21 17:19   ` Stefan Hajnoczi
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 16/23] monitor: send event when command queue full Peter Xu
2018-02-21 17:23   ` Stefan Hajnoczi
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 17/23] qapi: introduce new cmd option "allow-oob" Peter Xu
2018-03-08 10:04   ` Igor Mammedov
2018-03-08 11:43     ` Peter Xu
2018-03-08 11:51     ` Peter Xu [this message]
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 18/23] qmp: support out-of-band (oob) execution Peter Xu
2018-02-21 17:34   ` Stefan Hajnoczi
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 19/23] qmp: isolate responses into io thread Peter Xu
2018-02-21 17:44   ` Stefan Hajnoczi
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 20/23] monitor: enable IO thread for (qmp & !mux) typed Peter Xu
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 21/23] qmp: add command "x-oob-test" Peter Xu
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 22/23] tests: qmp-test: verify command batching Peter Xu
2018-01-24  5:39 ` [Qemu-devel] [PATCH v7 23/23] tests: qmp-test: add oob test Peter Xu
2018-01-25  2:35 ` [Qemu-devel] [PATCH v7 00/23] QMP: out-of-band (OOB) execution support Peter Xu
2018-01-25 10:01   ` Dr. David Alan Gilbert
2018-02-08  6:44 ` Peter Xu
2018-02-21 17:45 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180308115149.GG32252@xz-mi \
    --to=peterx@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=famz@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=shajnocz@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.