From: Christoph Hellwig <hch@lst.de>
To: Jiufei Xue <jiufei.xue@linux.alibaba.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: bio_check_eod() needs to consider partition
Date: Thu, 8 Mar 2018 15:40:30 +0100 [thread overview]
Message-ID: <20180308144030.GA23266@lst.de> (raw)
In-Reply-To: <760fb684-8267-7747-69a7-a11eca4d3424@linux.alibaba.com>
On Thu, Mar 08, 2018 at 04:17:19PM +0800, Jiufei Xue wrote:
> Hi Christoph,
>
> On 2018/3/8 下午3:46, Christoph Hellwig wrote:
> > bio_check_eod() should check partiton size not the whole disk if
> > bio->bi_partno is non-zero.
> >
> I think the check should be done twice if the bio->bi_partno is not zero,
> one for the partition, and another for the whole disk after remap which
> is add in the commit 5ddfe9691c91
> ("md: check bio address after mapping through partitions").
I disagree. See my other mail - if it fits inside the partition the
partition rescan code already made sure it also fits inside the device.
next prev parent reply other threads:[~2018-03-08 14:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 7:46 [PATCH] block: bio_check_eod() needs to consider partition Christoph Hellwig
2018-03-08 8:17 ` Jiufei Xue
2018-03-08 14:40 ` Christoph Hellwig [this message]
2018-03-08 21:09 ` Jens Axboe
2018-03-13 8:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308144030.GA23266@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jiufei.xue@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.