From mboxrd@z Thu Jan 1 00:00:00 1970 From: martin@kaiser.cx (Martin Kaiser) Date: Thu, 8 Mar 2018 16:38:32 +0100 Subject: [PATCH] ARM: dts: i.MX25: define SSI FIFO depth In-Reply-To: <20180308161135.1f3d3d18@karo-electronics.de> References: <1520373499-13623-1-git-send-email-martin@kaiser.cx> <20180308161135.1f3d3d18@karo-electronics.de> Message-ID: <20180308153832.GA28454@botnar.kaiser.cx> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Lothar, Thus wrote Lothar Wa?mann (LW at KARO-electronics.de): > > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > > index 9725705..cf70df2 100644 > > --- a/arch/arm/boot/dts/imx25.dtsi > > +++ b/arch/arm/boot/dts/imx25.dtsi > > @@ -269,6 +269,7 @@ > > dmas = <&sdma 24 1 0>, > > <&sdma 25 1 0>; > > dma-names = "rx", "tx"; > > + fsl,fifo-depth = <15>; > > status = "disabled"; > > }; > > @@ -329,6 +330,7 @@ > > dmas = <&sdma 28 1 0>, > > <&sdma 29 1 0>; > > dma-names = "rx", "tx"; > > + fsl,fifo-depth = <15>; > > status = "disabled"; > > }; > You are changing the global .dtsi file. Did you test this change with > all devices that are affected by it? I changed the hardware description of the imx25 SSI to match the reference manual. I did test this change on an imx25 board with audio playback. This uses the SSI description I modified. I verified that the driver is actually taking the modified setting into account and that this causes no problems. As of today, this setting is used by the fsl_ssi driver to set the fifo water level for dma requests. Of course, I don't have access to the enitre range of supported imx25 boards and I don't think this is required for submitting patches. Do you have any indication why this patch should not be merged? Best regards, Martin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Kaiser Subject: Re: [PATCH] ARM: dts: i.MX25: define SSI FIFO depth Date: Thu, 8 Mar 2018 16:38:32 +0100 Message-ID: <20180308153832.GA28454@botnar.kaiser.cx> References: <1520373499-13623-1-git-send-email-martin@kaiser.cx> <20180308161135.1f3d3d18@karo-electronics.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20180308161135.1f3d3d18@karo-electronics.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Lothar =?iso-8859-1?Q?Wa=DFmann?= Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, Rob Herring , Sascha Hauer , Fabio Estevam , Shawn Guo , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi Lothar, Thus wrote Lothar Wa=DFmann (LW@KARO-electronics.de): > > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > > index 9725705..cf70df2 100644 > > --- a/arch/arm/boot/dts/imx25.dtsi > > +++ b/arch/arm/boot/dts/imx25.dtsi > > @@ -269,6 +269,7 @@ > > dmas =3D <&sdma 24 1 0>, > > <&sdma 25 1 0>; > > dma-names =3D "rx", "tx"; > > + fsl,fifo-depth =3D <15>; > > status =3D "disabled"; > > }; > > @@ -329,6 +330,7 @@ > > dmas =3D <&sdma 28 1 0>, > > <&sdma 29 1 0>; > > dma-names =3D "rx", "tx"; > > + fsl,fifo-depth =3D <15>; > > status =3D "disabled"; > > }; > You are changing the global .dtsi file. Did you test this change with > all devices that are affected by it? I changed the hardware description of the imx25 SSI to match the reference manual. I did test this change on an imx25 board with audio playback. This uses the SSI description I modified. I verified that the driver is actually taking the modified setting into account and that this causes no problems. As of today, this setting is used by the fsl_ssi driver to set the fifo water level for dma requests. Of course, I don't have access to the enitre range of supported imx25 boards and I don't think this is required for submitting patches. Do you have any indication why this patch should not be merged? Best regards, Martin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755993AbeCHPi5 (ORCPT ); Thu, 8 Mar 2018 10:38:57 -0500 Received: from botnar.kaiser.cx ([176.28.20.183]:43156 "EHLO botnar.kaiser.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755624AbeCHPiz (ORCPT ); Thu, 8 Mar 2018 10:38:55 -0500 Date: Thu, 8 Mar 2018 16:38:32 +0100 From: Martin Kaiser To: Lothar =?iso-8859-1?Q?Wa=DFmann?= Cc: Shawn Guo , Sascha Hauer , Fabio Estevam , Rob Herring , Mark Rutland , Russell King , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: i.MX25: define SSI FIFO depth Message-ID: <20180308153832.GA28454@botnar.kaiser.cx> References: <1520373499-13623-1-git-send-email-martin@kaiser.cx> <20180308161135.1f3d3d18@karo-electronics.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180308161135.1f3d3d18@karo-electronics.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lothar, Thus wrote Lothar Waßmann (LW@KARO-electronics.de): > > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > > index 9725705..cf70df2 100644 > > --- a/arch/arm/boot/dts/imx25.dtsi > > +++ b/arch/arm/boot/dts/imx25.dtsi > > @@ -269,6 +269,7 @@ > > dmas = <&sdma 24 1 0>, > > <&sdma 25 1 0>; > > dma-names = "rx", "tx"; > > + fsl,fifo-depth = <15>; > > status = "disabled"; > > }; > > @@ -329,6 +330,7 @@ > > dmas = <&sdma 28 1 0>, > > <&sdma 29 1 0>; > > dma-names = "rx", "tx"; > > + fsl,fifo-depth = <15>; > > status = "disabled"; > > }; > You are changing the global .dtsi file. Did you test this change with > all devices that are affected by it? I changed the hardware description of the imx25 SSI to match the reference manual. I did test this change on an imx25 board with audio playback. This uses the SSI description I modified. I verified that the driver is actually taking the modified setting into account and that this causes no problems. As of today, this setting is used by the fsl_ssi driver to set the fifo water level for dma requests. Of course, I don't have access to the enitre range of supported imx25 boards and I don't think this is required for submitting patches. Do you have any indication why this patch should not be merged? Best regards, Martin