From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCHv3] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4 Date: Thu, 8 Mar 2018 08:06:44 -0800 Message-ID: <20180308160644.GJ5799@atomide.com> References: <20180307145640.93867-1-tony@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Kishon Vijay Abraham I Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, Mark Rutland , Marcel Partap , Michael Scott , Rob Herring List-Id: linux-omap@vger.kernel.org * Kishon Vijay Abraham I [180308 08:23]: > On Wednesday 07 March 2018 08:26 PM, Tony Lindgren wrote: > > +config PHY_MAPPHONE_MDM6600 > > + tristate "Motorola Mapphone MDM6600 modem USB PHY driver" > > + depends on OF && USB_SUPPORT > > + select GENERIC_PHY > > + select USB_PHY > > given that OTG is removed, USB_PHY won't be required anymore. Sorry for not > stating this explicitly before. Oh OK I did not know that. > > + ddata->dev = &pdev->dev; > > + ddata->phy.dev = ddata->dev; > > + ddata->phy.label = "phy_mdm6600"; > > + ddata->phy.type = USB_PHY_TYPE_USB2; > > All of this can be removed since usb_phy is not required. > > + usb_add_phy_dev(&ddata->phy); > > This should also be removed. OK cool, will remove and post v4 hopefully tonight at some point. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [PATCHv3] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4 From: Tony Lindgren Message-Id: <20180308160644.GJ5799@atomide.com> Date: Thu, 8 Mar 2018 08:06:44 -0800 To: Kishon Vijay Abraham I Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, Mark Rutland , Marcel Partap , Michael Scott , Rob Herring List-ID: KiBLaXNob24gVmlqYXkgQWJyYWhhbSBJIDxraXNob25AdGkuY29tPiBbMTgwMzA4IDA4OjIzXToK PiBPbiBXZWRuZXNkYXkgMDcgTWFyY2ggMjAxOCAwODoyNiBQTSwgVG9ueSBMaW5kZ3JlbiB3cm90 ZToKPiA+ICtjb25maWcgUEhZX01BUFBIT05FX01ETTY2MDAKPiA+ICsJdHJpc3RhdGUgIk1vdG9y b2xhIE1hcHBob25lIE1ETTY2MDAgbW9kZW0gVVNCIFBIWSBkcml2ZXIiCj4gPiArCWRlcGVuZHMg b24gT0YgJiYgVVNCX1NVUFBPUlQKPiA+ICsJc2VsZWN0IEdFTkVSSUNfUEhZCj4gPiArCXNlbGVj dCBVU0JfUEhZCj4gCj4gZ2l2ZW4gdGhhdCBPVEcgaXMgcmVtb3ZlZCwgVVNCX1BIWSB3b24ndCBi ZSByZXF1aXJlZCBhbnltb3JlLiBTb3JyeSBmb3Igbm90Cj4gc3RhdGluZyB0aGlzIGV4cGxpY2l0 bHkgYmVmb3JlLgoKT2ggT0sgSSBkaWQgbm90IGtub3cgdGhhdC4KCj4gPiArCWRkYXRhLT5kZXYg PSAmcGRldi0+ZGV2Owo+ID4gKwlkZGF0YS0+cGh5LmRldiA9IGRkYXRhLT5kZXY7Cj4gPiArCWRk YXRhLT5waHkubGFiZWwgPSAicGh5X21kbTY2MDAiOwo+ID4gKwlkZGF0YS0+cGh5LnR5cGUgPSBV U0JfUEhZX1RZUEVfVVNCMjsKPiAKPiBBbGwgb2YgdGhpcyBjYW4gYmUgcmVtb3ZlZCBzaW5jZSB1 c2JfcGh5IGlzIG5vdCByZXF1aXJlZC4KCj4gPiArCXVzYl9hZGRfcGh5X2RldigmZGRhdGEtPnBo eSk7Cj4gCj4gVGhpcyBzaG91bGQgYWxzbyBiZSByZW1vdmVkLgoKT0sgY29vbCwgd2lsbCByZW1v dmUgYW5kIHBvc3QgdjQgaG9wZWZ1bGx5IHRvbmlnaHQgYXQgc29tZQpwb2ludC4KClJlZ2FyZHMs CgpUb255Ci0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAi dW5zdWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jk b21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5r ZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK