From mboxrd@z Thu Jan 1 00:00:00 1970 From: LW@KARO-electronics.de (Lothar =?UTF-8?B?V2HDn21hbm4=?=) Date: Thu, 8 Mar 2018 16:11:35 +0100 Subject: [PATCH] ARM: dts: i.MX25: define SSI FIFO depth In-Reply-To: <1520373499-13623-1-git-send-email-martin@kaiser.cx> References: <1520373499-13623-1-git-send-email-martin@kaiser.cx> Message-ID: <20180308161135.1f3d3d18@karo-electronics.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Tue, 6 Mar 2018 22:58:19 +0100 Martin Kaiser wrote: > According to the i.MX25 reference manuals, each SSI has four FIFOs. All > of those FIFOs can store up to 15 entries. > > The fsl_ssi driver's internal default for the FIFO depth in 8. Set our > non-default FIFO depth explicitly in the Device Tree. > > Signed-off-by: Martin Kaiser > --- > arch/arm/boot/dts/imx25.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > index 9725705..cf70df2 100644 > --- a/arch/arm/boot/dts/imx25.dtsi > +++ b/arch/arm/boot/dts/imx25.dtsi > @@ -269,6 +269,7 @@ > dmas = <&sdma 24 1 0>, > <&sdma 25 1 0>; > dma-names = "rx", "tx"; > + fsl,fifo-depth = <15>; > status = "disabled"; > }; > > @@ -329,6 +330,7 @@ > dmas = <&sdma 28 1 0>, > <&sdma 29 1 0>; > dma-names = "rx", "tx"; > + fsl,fifo-depth = <15>; > status = "disabled"; > }; > You are changing the global .dtsi file. Did you test this change with all devices that are affected by it? Lothar Wa?mann From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= Subject: Re: [PATCH] ARM: dts: i.MX25: define SSI FIFO depth Date: Thu, 8 Mar 2018 16:11:35 +0100 Message-ID: <20180308161135.1f3d3d18@karo-electronics.de> References: <1520373499-13623-1-git-send-email-martin@kaiser.cx> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1520373499-13623-1-git-send-email-martin@kaiser.cx> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Martin Kaiser Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, Rob Herring , Sascha Hauer , Fabio Estevam , Shawn Guo , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org SGksCgpPbiBUdWUsICA2IE1hciAyMDE4IDIyOjU4OjE5ICswMTAwIE1hcnRpbiBLYWlzZXIgd3Jv dGU6Cj4gQWNjb3JkaW5nIHRvIHRoZSBpLk1YMjUgcmVmZXJlbmNlIG1hbnVhbHMsIGVhY2ggU1NJ IGhhcyBmb3VyIEZJRk9zLiBBbGwKPiBvZiB0aG9zZSBGSUZPcyBjYW4gc3RvcmUgdXAgdG8gMTUg ZW50cmllcy4KPiAKPiBUaGUgZnNsX3NzaSBkcml2ZXIncyBpbnRlcm5hbCBkZWZhdWx0IGZvciB0 aGUgRklGTyBkZXB0aCBpbiA4LiBTZXQgb3VyCj4gbm9uLWRlZmF1bHQgRklGTyBkZXB0aCBleHBs aWNpdGx5IGluIHRoZSBEZXZpY2UgVHJlZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYXJ0aW4gS2Fp c2VyIDxtYXJ0aW5Aa2Fpc2VyLmN4Pgo+IC0tLQo+ICBhcmNoL2FybS9ib290L2R0cy9pbXgyNS5k dHNpIHwgMiArKwo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAt LWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL2lteDI1LmR0c2kgYi9hcmNoL2FybS9ib290L2R0cy9p bXgyNS5kdHNpCj4gaW5kZXggOTcyNTcwNS4uY2Y3MGRmMiAxMDA2NDQKPiAtLS0gYS9hcmNoL2Fy bS9ib290L2R0cy9pbXgyNS5kdHNpCj4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvaW14MjUuZHRz aQo+IEBAIC0yNjksNiArMjY5LDcgQEAKPiAgCQkJCWRtYXMgPSA8JnNkbWEgMjQgMSAwPiwKPiAg CQkJCSAgICAgICA8JnNkbWEgMjUgMSAwPjsKPiAgCQkJCWRtYS1uYW1lcyA9ICJyeCIsICJ0eCI7 Cj4gKwkJCQlmc2wsZmlmby1kZXB0aCA9IDwxNT47Cj4gIAkJCQlzdGF0dXMgPSAiZGlzYWJsZWQi Owo+ICAJCQl9Owo+ICAKPiBAQCAtMzI5LDYgKzMzMCw3IEBACj4gIAkJCQlkbWFzID0gPCZzZG1h IDI4IDEgMD4sCj4gIAkJCQkgICAgICAgPCZzZG1hIDI5IDEgMD47Cj4gIAkJCQlkbWEtbmFtZXMg PSAicngiLCAidHgiOwo+ICsJCQkJZnNsLGZpZm8tZGVwdGggPSA8MTU+Owo+ICAJCQkJc3RhdHVz ID0gImRpc2FibGVkIjsKPiAgCQkJfTsKPiAgCllvdSBhcmUgY2hhbmdpbmcgdGhlIGdsb2JhbCAu ZHRzaSBmaWxlLiBEaWQgeW91IHRlc3QgdGhpcyBjaGFuZ2Ugd2l0aAphbGwgZGV2aWNlcyB0aGF0 IGFyZSBhZmZlY3RlZCBieSBpdD8KCgpMb3RoYXIgV2HDn21hbm4KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756008AbeCHPbO convert rfc822-to-8bit (ORCPT ); Thu, 8 Mar 2018 10:31:14 -0500 Received: from smtprelay03.ispgateway.de ([80.67.31.37]:40322 "EHLO smtprelay03.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754580AbeCHPbL (ORCPT ); Thu, 8 Mar 2018 10:31:11 -0500 Date: Thu, 8 Mar 2018 16:11:35 +0100 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Martin Kaiser Cc: Shawn Guo , Sascha Hauer , Fabio Estevam , Rob Herring , Mark Rutland , Russell King , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: i.MX25: define SSI FIFO depth Message-ID: <20180308161135.1f3d3d18@karo-electronics.de> In-Reply-To: <1520373499-13623-1-git-send-email-martin@kaiser.cx> References: <1520373499-13623-1-git-send-email-martin@kaiser.cx> Organization: Ka-Ro electronics GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Df-Sender: bHdAa2Fyby1lbGVjdHJvbmljcy5kZQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, 6 Mar 2018 22:58:19 +0100 Martin Kaiser wrote: > According to the i.MX25 reference manuals, each SSI has four FIFOs. All > of those FIFOs can store up to 15 entries. > > The fsl_ssi driver's internal default for the FIFO depth in 8. Set our > non-default FIFO depth explicitly in the Device Tree. > > Signed-off-by: Martin Kaiser > --- > arch/arm/boot/dts/imx25.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > index 9725705..cf70df2 100644 > --- a/arch/arm/boot/dts/imx25.dtsi > +++ b/arch/arm/boot/dts/imx25.dtsi > @@ -269,6 +269,7 @@ > dmas = <&sdma 24 1 0>, > <&sdma 25 1 0>; > dma-names = "rx", "tx"; > + fsl,fifo-depth = <15>; > status = "disabled"; > }; > > @@ -329,6 +330,7 @@ > dmas = <&sdma 28 1 0>, > <&sdma 29 1 0>; > dma-names = "rx", "tx"; > + fsl,fifo-depth = <15>; > status = "disabled"; > }; > You are changing the global .dtsi file. Did you test this change with all devices that are affected by it? Lothar Waßmann