From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Habkost Subject: Re: [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post Date: Thu, 8 Mar 2018 17:03:45 -0300 Message-ID: <20180308200345.GD3417@localhost.localdomain> References: <1520530757-4477-1-git-send-email-ian.jackson@eu.citrix.com> <1520530757-4477-4-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eu1lb-0003hG-Sn for xen-devel@lists.xenproject.org; Thu, 08 Mar 2018 20:03:55 +0000 Content-Disposition: inline In-Reply-To: <1520530757-4477-4-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Ian Jackson Cc: Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Ross Lagerwall , Paolo Bonzini , Anthony PERARD , xen-devel@lists.xenproject.org, Richard Henderson List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBNYXIgMDgsIDIwMTggYXQgMDU6Mzk6MDlQTSArMDAwMCwgSWFuIEphY2tzb24gd3Jv dGU6ClsuLi5dCj4gZGlmZiAtLWdpdCBhL3ZsLmMgYi92bC5jCj4gaW5kZXggZGFlOTg2Yi4uZTZl OGUxZSAxMDA2NDQKPiAtLS0gYS92bC5jCj4gKysrIGIvdmwuYwo+IEBAIC00NzE5LDYgKzQ3MTks NyBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqKmFyZ3YsIGNoYXIgKiplbnZwKQo+ICAgICAg ICAgIHZtX3N0YXJ0KCk7Cj4gICAgICB9Cj4gIAo+ICsgICAgeGVuX3NldHVwX3Bvc3QoKTsKCkkg ZG9uJ3QgdGhpbmsgd2Ugc2hvdWxkIGhhdmUgYWNjZWxlcmF0b3Itc3BlY2lmaWMgY29kZSBpbiBt YWluKCksCmlmIHdlIGFscmVhZHkgaGF2ZSBhY2NlbGVyYXRvciBjbGFzc2VzIHRoYXQgY2FuIGFi c3RyYWN0IHRoYXQKb3V0LiAgSSBzdWdnZXN0IGFkZGluZyBhIEFjY2VsQ2xhc3M7OnNldHVwX3Bv c3QoKSBtZXRob2QgdGhhdCBjYW4KYmUgY2FsbGVkIGhlcmUuCgotLSAKRWR1YXJkbwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxp bmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5w cm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eu1lb-0007q2-IG for qemu-devel@nongnu.org; Thu, 08 Mar 2018 15:03:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eu1lW-0000ZH-MZ for qemu-devel@nongnu.org; Thu, 08 Mar 2018 15:03:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59404) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eu1lW-0000Yy-Hj for qemu-devel@nongnu.org; Thu, 08 Mar 2018 15:03:50 -0500 Date: Thu, 8 Mar 2018 17:03:45 -0300 From: Eduardo Habkost Message-ID: <20180308200345.GD3417@localhost.localdomain> References: <1520530757-4477-1-git-send-email-ian.jackson@eu.citrix.com> <1520530757-4477-4-git-send-email-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1520530757-4477-4-git-send-email-ian.jackson@eu.citrix.com> Subject: Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Jackson Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, Ross Lagerwall , Anthony PERARD , Juergen Gross , Stefano Stabellini , Paolo Bonzini , Richard Henderson , "Michael S. Tsirkin" On Thu, Mar 08, 2018 at 05:39:09PM +0000, Ian Jackson wrote: [...] > diff --git a/vl.c b/vl.c > index dae986b..e6e8e1e 100644 > --- a/vl.c > +++ b/vl.c > @@ -4719,6 +4719,7 @@ int main(int argc, char **argv, char **envp) > vm_start(); > } > > + xen_setup_post(); I don't think we should have accelerator-specific code in main(), if we already have accelerator classes that can abstract that out. I suggest adding a AccelClass;:setup_post() method that can be called here. -- Eduardo