All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Brad Mouring <brad.mouring@ni.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH] net: phy: Tell caller result of phy_change()
Date: Thu, 8 Mar 2018 21:47:23 +0100	[thread overview]
Message-ID: <20180308204723.GA26248@lunn.ch> (raw)
In-Reply-To: <20180308203157.10855-1-brad.mouring@ni.com>

> +++ b/drivers/net/phy/phy.c
> @@ -617,6 +617,8 @@ static void phy_error(struct phy_device *phydev)
>  	phy_trigger_machine(phydev, false);
>  }
>  
> +static irqreturn_t phy_change(struct phy_device *phydev);
> +

Hi Brad

Rather than add a forward declaration, please move phy_change().

       Thanks
              Andrew

  reply	other threads:[~2018-03-08 20:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07 22:50 [PATCH] net: phy: Move interrupt check from phy_check to phy_interrupt Brad Mouring
2018-03-08 16:29 ` Andrew Lunn
2018-03-08 16:46   ` Brad Mouring
2018-03-08 19:41 ` Sergei Shtylyov
2018-03-08 19:57   ` Sergei Shtylyov
2018-03-08 20:16   ` Brad Mouring
2018-03-08 20:25 ` Sergei Shtylyov
2018-03-08 20:31 ` [PATCH] net: phy: Tell caller result of phy_change() Brad Mouring
2018-03-08 20:47   ` Andrew Lunn [this message]
2018-03-08 22:23   ` [PATCH net v3] " Brad Mouring
2018-03-12 14:34     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180308204723.GA26248@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=brad.mouring@ni.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.