From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package: dropbear: make PATH configurable
Date: Thu, 8 Mar 2018 22:48:01 +0100 [thread overview]
Message-ID: <20180308214801.GA8180@scaer> (raw)
In-Reply-To: <20180308214403.94906-1-mmayer@broadcom.com>
Markus, All,
On 2018-03-08 13:44 -0800, Markus Mayer spake thusly:
> Make the default PATH dropbear is using configurable.
>
> If not specified, it will continue to default to dropbear's
> DEFAULT_PATH.
Isn't it better to jut let the user provide a ~/.profile file which
actually sets the PATH?
Regards,
Yann E. MORIN.
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> ---
>
> Please let me know what you think. Thanks.
>
> package/dropbear/Config.in | 6 ++++++
> package/dropbear/dropbear.mk | 8 ++++++++
> 2 files changed, 14 insertions(+)
>
> diff --git a/package/dropbear/Config.in b/package/dropbear/Config.in
> index 6700778161ba..d38ecf50834a 100644
> --- a/package/dropbear/Config.in
> +++ b/package/dropbear/Config.in
> @@ -55,4 +55,10 @@ config BR2_PACKAGE_DROPBEAR_LASTLOG
> Enable logging of dropbear access to lastlog. Notice that
> Buildroot does not generate lastlog by default.
>
> +config BR2_PACKAGE_DROPBEAR_PATH
> + string "dropbear default path"
> + help
> + Use the path specified here as dropbear's default path.
> + If not specified, dropbear will use "/usr/bin:/bin".
> +
> endif
> diff --git a/package/dropbear/dropbear.mk b/package/dropbear/dropbear.mk
> index 01a1a07b7696..ddbedf3bce93 100644
> --- a/package/dropbear/dropbear.mk
> +++ b/package/dropbear/dropbear.mk
> @@ -51,6 +51,14 @@ define DROPBEAR_DISABLE_STANDALONE
> $(SED) 's:\(#define NON_INETD_MODE\):/*\1 */:' $(@D)/options.h
> endef
>
> +ifneq ($(BR2_PACKAGE_DROPBEAR_PATH),"")
> +define DROPBEAR_CUSTOM_PATH
> + $(SED) 's|^\(#define DEFAULT_PATH\).*|\1 $(BR2_PACKAGE_DROPBEAR_PATH)|' $(@D)/options.h
> +endef
> +
> +DROPBEAR_POST_EXTRACT_HOOKS += DROPBEAR_CUSTOM_PATH
> +endif
> +
> define DROPBEAR_INSTALL_INIT_SYSTEMD
> $(INSTALL) -D -m 644 package/dropbear/dropbear.service \
> $(TARGET_DIR)/usr/lib/systemd/system/dropbear.service
> --
> 2.7.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-03-08 21:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 21:44 [Buildroot] [PATCH] package: dropbear: make PATH configurable Markus Mayer
2018-03-08 21:48 ` Yann E. MORIN [this message]
2018-03-08 22:29 ` Markus Mayer
2018-03-09 0:34 ` Christopher McCrory
2018-03-09 17:10 ` Christopher McCrory
2018-03-09 21:29 ` Markus Mayer
2018-03-09 9:04 ` Nicolas Cavallari
-- strict thread matches above, loose matches on Subject: below --
2018-03-09 22:41 [Buildroot] [PATCH v2] " Markus Mayer
2018-07-01 1:57 ` [Buildroot] [PATCH] " Carlos Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308214801.GA8180@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.