From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Simon Shields <simon@lineageos.org>,
linux-leds@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: document Panasonic AN30259A bindings
Date: Thu, 8 Mar 2018 23:54:12 +0100 [thread overview]
Message-ID: <20180308225412.GA11646@amd> (raw)
In-Reply-To: <973256fd-8394-1b41-9ca1-846442515f62@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
Hi!
> > + led@1 {
> > + reg = <1>;
> > + linux,default-trigger = "heartbeat";
> > + label = "an30259a:red:notification";
>
> s/an30259a:red:notification/red:notification/
>
> Let's drop devicename section from label, and make it a LED class
> driver responsibility to prepend the label with devicename when
> composing LED class device name.
Is it good idea?
(Some existing bindings specify three-part label in the label, some do
not. Documentation/devicetree/bindings/leds/leds-netxbig.txt
vs. Documentation/devicetree/bindings/leds/leds-mt6323.txt :-( We
should really solve that somehow).
I'd really like to see input0:white:numlock in the name, so same
software has a chance to work on PC and ARM notebook. Prepending
an30259a in the driver will break that...
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-03-08 22:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 0:47 [PATCH v2 0/2] Panasonic AN30259A support Simon Shields
2018-03-07 0:47 ` [PATCH v2 1/2] dt-bindings: leds: document Panasonic AN30259A bindings Simon Shields
2018-03-07 21:58 ` Pavel Machek
2018-03-08 2:02 ` Rob Herring
2018-03-08 22:17 ` Jacek Anaszewski
2018-03-08 22:54 ` Pavel Machek [this message]
2018-03-09 22:33 ` Jacek Anaszewski
2018-03-07 0:47 ` [PATCH v2 2/2] leds: add Panasonic AN30259A support Simon Shields
2018-03-07 22:07 ` Pavel Machek
2018-03-08 0:48 ` Simon Shields
2018-03-08 22:17 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308225412.GA11646@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=simon@lineageos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.