From: "bfields@fieldses.org" <bfields@fieldses.org>
To: Trond Myklebust <trondmy@primarydata.com>
Cc: "smayhew@redhat.com" <smayhew@redhat.com>,
"anna.schumaker@netapp.com" <anna.schumaker@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfs: nfs_commit_inode should redirty inode if the inode has outstanding requests
Date: Thu, 8 Mar 2018 21:46:00 -0500 [thread overview]
Message-ID: <20180309024600.GA20826@fieldses.org> (raw)
In-Reply-To: <1520546500.91818.2.camel@primarydata.com>
On Thu, Mar 08, 2018 at 10:01:42PM +0000, Trond Myklebust wrote:
> On Thu, 2018-03-08 at 16:39 -0500, bfields@fieldses.org wrote:
> > On Thu, Mar 08, 2018 at 08:09:01AM -0500, Scott Mayhew wrote:
> > > Yes, this works. I ran it through a dozen fio runs on v4.1 and
> > > 1000 runs
> > > of generic/247 on v3/v4.0/v4.1/v4.2 and didn't see any EBUSY
> > > errors.
> > > Also ran the xfstests "quick" group (~80-90 tests) plus generic/074
> > > on
> > > v3/v4.0/v4.1/v4.2. Finally, I double checked the panic on umount
> > > issue
> > > that dc4fd9ab01ab3 fixed and that still works too.
> >
> > Works for me too.
> >
> > (Yeah, I see there's a new patch. Testing queued up but not run
> > yet...).
>
> Sorry for pulling the "new patch switch" on you both, but I figured it
> would be better to re-examine where the requirement for the dirty flag
> is coming from, and to ensure that we meet that requirement once and
> for all.
No problem. My tests are passing on the new patch as well.
--b.
prev parent reply other threads:[~2018-03-09 2:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 16:00 [PATCH] nfs: nfs_commit_inode should redirty inode if the inode has outstanding requests Scott Mayhew
2018-03-02 16:52 ` Trond Myklebust
2018-03-02 17:04 ` Trond Myklebust
2018-03-05 21:16 ` J. Bruce Fields
2018-03-05 21:48 ` Trond Myklebust
2018-03-07 19:53 ` Scott Mayhew
2018-03-07 20:38 ` Trond Myklebust
2018-03-08 13:09 ` Scott Mayhew
2018-03-08 17:13 ` Trond Myklebust
2018-03-12 12:07 ` Scott Mayhew
2018-03-12 12:32 ` Trond Myklebust
2018-03-08 21:39 ` bfields
2018-03-08 22:01 ` Trond Myklebust
2018-03-09 2:46 ` bfields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180309024600.GA20826@fieldses.org \
--to=bfields@fieldses.org \
--cc=anna.schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=smayhew@redhat.com \
--cc=trondmy@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.