From: Olaf Hering <olaf@aepfle.de>
To: Juergen Gross <jgross@suse.com>
Cc: ian.jackson@citrix.com, wei.liu2@citrix.com,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] tools/xenstore: add libdl dependency to libxenstore
Date: Fri, 9 Mar 2018 09:36:33 +0100 [thread overview]
Message-ID: <20180309083633.GA12975@aepfle.de> (raw)
In-Reply-To: <c0db67f3-707d-6e86-0fbd-7dfed9178d99@suse.com>
[-- Attachment #1.1: Type: text/plain, Size: 1251 bytes --]
On Wed, Mar 07, Juergen Gross wrote:
> On 07/03/18 13:06, ian.jackson@citrix.com wrote:
> > Juergen Gross writes ("Re: [PATCH] tools/xenstore: add libdl dependency to libxenstore"):
> >> On 07/03/18 12:19, Ian Jackson wrote:
> >>> Juergen Gross writes ("[PATCH] tools/xenstore: add libdl dependency to libxenstore"):
> >>>> libxenstore.so.$(MAJOR).$(MINOR): LDFLAGS += -ldl
> >>>> +else
> >>>> +PKG_CONFIG_REMOVE += dl
> >>> What is this ?
> >> -ldl is needed on Linux only, but I didn't want to add a Linux specific
> >> pkg-config file. So I'm removing the dependency in case we are not on
> >> Linux.
> > Sorry, I was grepping an older xen tree, so I didn't see where this
> > variable was honoured.
> > Will this work, though, when what has to be done is to remove -ldl
> > from Libs, rather than from Requires ?
> Yes, I've tested it to work (in V2 we have: PKG_CONFIG_REMOVE += -ldl)
This breaks libvirt.
m4/virt-driver-xen.m4 tries to use just '-lxenstore' and the test fails
with missing 'dlsym'. If I adjust this .m4 file to use pkgconfig it
still fails. Only appending '-ldl' to XEN_LIBS will help. So to me it
looks like -ldl is now a hard requirement when linking to
libxenstore.so. I used 20180307T163340.c9bd8a7365 for testing.
Olaf
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-03-09 8:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 10:17 [PATCH] tools/xenstore: add libdl dependency to libxenstore Juergen Gross
2018-03-07 10:29 ` Wei Liu
2018-03-07 11:01 ` Juergen Gross
2018-03-07 11:04 ` Wei Liu
2018-03-07 11:19 ` Ian Jackson
2018-03-07 11:49 ` Juergen Gross
2018-03-07 12:06 ` ian.jackson
2018-03-07 12:15 ` Juergen Gross
2018-03-09 8:36 ` Olaf Hering [this message]
2018-03-09 10:00 ` Juergen Gross
2018-03-09 10:23 ` Olaf Hering
2018-03-09 11:08 ` Olaf Hering
2018-03-09 16:12 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180309083633.GA12975@aepfle.de \
--to=olaf@aepfle.de \
--cc=ian.jackson@citrix.com \
--cc=jgross@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.