From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay3-d.mail.gandi.net ([217.70.183.195]:58544 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045AbeCIJEc (ORCPT ); Fri, 9 Mar 2018 04:04:32 -0500 Date: Fri, 9 Mar 2018 10:04:22 +0100 From: jacopo mondi To: Geert Uytterhoeven Cc: Jacopo Mondi , Archit Taneja , Andrzej Hajda , Laurent Pinchart , David Airlie , Simon Horman , Magnus Damm , Niklas =?utf-8?Q?S=C3=B6derlund?= , Sergei Shtylyov , Rob Herring , Mark Rutland , DRI Development , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Subject: Re: [PATCH 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder Message-ID: <20180309090422.GD14819@w540> References: <1520522643-11756-1-git-send-email-jacopo+renesas@jmondi.org> <1520522643-11756-2-git-send-email-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Geert, thanks for review On Fri, Mar 09, 2018 at 09:10:55AM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Thu, Mar 8, 2018 at 4:24 PM, Jacopo Mondi wrote: > > Document Thine THC63LVD1024 LVDS decoder. > > > > Signed-off-by: Jacopo Mondi > > Thanks for your patch! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > > @@ -0,0 +1,59 @@ > > +THine Electronics THC63LVD1024 LVDS receiver > > Thine > > > +-------------------------------------------- > > + > > +The THC63LVD1024 is an LVDS receiver designed to convert multiple LVDS streams > > +to digital CMOS/TTL parallel data. > > + > > +Required properties: > > +- compatible: Shall be one of the following: > > + "thine,thc63lvd1024", > > + "lvds-decoder" > > What's the purpose of the second compatible value? > When should it be used? It is probably my bad having started with a generic LVDS decoder in mind and having then added properties specific to THC63LVD1024 to the driver and its bindings. "lvds,decoder" can be used when the chip is completely transparent to the SoC and none of the optional properties I have described in the bindings are specified (a generic "power-gpios" apart, see Andrzej comments on "pwdn-gpios" property). Also, I should make the driver behavior depend on the matched compatible string. When "lvds-decoder" is matched, it will just look for an optional power down gpio, when "thc63lvd1024" is matched, all of its Vcc supplies, pwdn gpio and oe gpios will be queried and, if present, eventually used in enable/disable routines. I'm just not sure how to describe that in bindings. Would something like the following work? Optional properties for "lvds,decoder" - power-gpios: Power control GPIOs Optional properties for "thine,thc63lvd1024" - pwdn-gpios: ... - oe-gpios: ... - supply-vcc: ... - supply-cvcc: ... - supply-pvcc: ... - supply-lvcc: ... Thanks j > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: jacopo mondi Subject: Re: [PATCH 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder Date: Fri, 9 Mar 2018 10:04:22 +0100 Message-ID: <20180309090422.GD14819@w540> References: <1520522643-11756-1-git-send-email-jacopo+renesas@jmondi.org> <1520522643-11756-2-git-send-email-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Geert Uytterhoeven Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sergei Shtylyov , David Airlie , DRI Development , Magnus Damm , Linux Kernel Mailing List , Rob Herring , Linux-Renesas , Simon Horman , Jacopo Mondi , Laurent Pinchart , Niklas =?utf-8?Q?S=C3=B6derlund?= List-Id: devicetree@vger.kernel.org SGkgR2VlcnQsCiAgIHRoYW5rcyBmb3IgcmV2aWV3CgpPbiBGcmksIE1hciAwOSwgMjAxOCBhdCAw OToxMDo1NUFNICswMTAwLCBHZWVydCBVeXR0ZXJob2V2ZW4gd3JvdGU6Cj4gSGkgSmFjb3BvLAo+ Cj4gT24gVGh1LCBNYXIgOCwgMjAxOCBhdCA0OjI0IFBNLCBKYWNvcG8gTW9uZGkgPGphY29wbyty ZW5lc2FzQGptb25kaS5vcmc+IHdyb3RlOgo+ID4gRG9jdW1lbnQgVGhpbmUgVEhDNjNMVkQxMDI0 IExWRFMgZGVjb2Rlci4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBKYWNvcG8gTW9uZGkgPGphY29w bytyZW5lc2FzQGptb25kaS5vcmc+Cj4KPiBUaGFua3MgZm9yIHlvdXIgcGF0Y2ghCj4KPiA+IC0t LSAvZGV2L251bGwKPiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9k aXNwbGF5L2JyaWRnZS90aGluZSx0aGM2M2x2ZDEwMjQudHh0Cj4gPiBAQCAtMCwwICsxLDU5IEBA Cj4gPiArVEhpbmUgRWxlY3Ryb25pY3MgVEhDNjNMVkQxMDI0IExWRFMgcmVjZWl2ZXIKPgo+IFRo aW5lCj4KPiA+ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ ID4gKwo+ID4gK1RoZSBUSEM2M0xWRDEwMjQgaXMgYW4gTFZEUyByZWNlaXZlciBkZXNpZ25lZCB0 byBjb252ZXJ0IG11bHRpcGxlIExWRFMgc3RyZWFtcwo+ID4gK3RvIGRpZ2l0YWwgQ01PUy9UVEwg cGFyYWxsZWwgZGF0YS4KPiA+ICsKPiA+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ID4gKy0gY29t cGF0aWJsZTogU2hhbGwgYmUgb25lIG9mIHRoZSBmb2xsb3dpbmc6Cj4gPiArICAidGhpbmUsdGhj NjNsdmQxMDI0IiwKPiA+ICsgICJsdmRzLWRlY29kZXIiCj4KPiBXaGF0J3MgdGhlIHB1cnBvc2Ug b2YgdGhlIHNlY29uZCBjb21wYXRpYmxlIHZhbHVlPwo+IFdoZW4gc2hvdWxkIGl0IGJlIHVzZWQ/ CgpJdCBpcyBwcm9iYWJseSBteSBiYWQgaGF2aW5nIHN0YXJ0ZWQgd2l0aCBhIGdlbmVyaWMgTFZE UyBkZWNvZGVyIGluCm1pbmQgYW5kIGhhdmluZyB0aGVuIGFkZGVkIHByb3BlcnRpZXMgc3BlY2lm aWMgdG8gVEhDNjNMVkQxMDI0IHRvIHRoZQpkcml2ZXIgYW5kIGl0cyBiaW5kaW5ncy4KCiJsdmRz LGRlY29kZXIiIGNhbiBiZSB1c2VkIHdoZW4gdGhlIGNoaXAgaXMgY29tcGxldGVseSB0cmFuc3Bh cmVudCB0bwp0aGUgU29DIGFuZCBub25lIG9mIHRoZSBvcHRpb25hbCBwcm9wZXJ0aWVzIEkgaGF2 ZSBkZXNjcmliZWQgaW4gdGhlCmJpbmRpbmdzIGFyZSBzcGVjaWZpZWQgKGEgZ2VuZXJpYyAicG93 ZXItZ3Bpb3MiIGFwYXJ0LCBzZWUgQW5kcnplagpjb21tZW50cyBvbiAicHdkbi1ncGlvcyIgcHJv cGVydHkpLgoKQWxzbywgSSBzaG91bGQgbWFrZSB0aGUgZHJpdmVyIGJlaGF2aW9yIGRlcGVuZCBv biB0aGUgbWF0Y2hlZCBjb21wYXRpYmxlCnN0cmluZy4gV2hlbiAibHZkcy1kZWNvZGVyIiBpcyBt YXRjaGVkLCBpdCB3aWxsIGp1c3QgbG9vayBmb3IgYW4Kb3B0aW9uYWwgcG93ZXIgZG93biBncGlv LCB3aGVuICJ0aGM2M2x2ZDEwMjQiIGlzIG1hdGNoZWQsIGFsbCBvZiBpdHMKVmNjIHN1cHBsaWVz LCBwd2RuIGdwaW8gYW5kIG9lIGdwaW9zIHdpbGwgYmUgcXVlcmllZCBhbmQsIGlmIHByZXNlbnQs CmV2ZW50dWFsbHkgdXNlZCBpbiBlbmFibGUvZGlzYWJsZSByb3V0aW5lcy4KCkknbSBqdXN0IG5v dCBzdXJlIGhvdyB0byBkZXNjcmliZSB0aGF0IGluIGJpbmRpbmdzLiBXb3VsZCBzb21ldGhpbmcK bGlrZSB0aGUgZm9sbG93aW5nIHdvcms/CgpPcHRpb25hbCBwcm9wZXJ0aWVzIGZvciAibHZkcyxk ZWNvZGVyIgotIHBvd2VyLWdwaW9zOiBQb3dlciBjb250cm9sIEdQSU9zCgpPcHRpb25hbCBwcm9w ZXJ0aWVzIGZvciAidGhpbmUsdGhjNjNsdmQxMDI0IgotIHB3ZG4tZ3Bpb3M6IC4uLgotIG9lLWdw aW9zOiAuLi4KLSBzdXBwbHktdmNjOiAuLi4KLSBzdXBwbHktY3ZjYzogLi4uCi0gc3VwcGx5LXB2 Y2M6IC4uLgotIHN1cHBseS1sdmNjOiAuLi4KClRoYW5rcwogICBqCgo+Cj4gR3J7b2V0amUsZWV0 aW5nfXMsCj4KPiAgICAgICAgICAgICAgICAgICAgICAgICBHZWVydAo+Cj4gLS0KPiBHZWVydCBV eXR0ZXJob2V2ZW4gLS0gVGhlcmUncyBsb3RzIG9mIExpbnV4IGJleW9uZCBpYTMyIC0tIGdlZXJ0 QGxpbnV4LW02OGsub3JnCj4KPiBJbiBwZXJzb25hbCBjb252ZXJzYXRpb25zIHdpdGggdGVjaG5p Y2FsIHBlb3BsZSwgSSBjYWxsIG15c2VsZiBhIGhhY2tlci4gQnV0Cj4gd2hlbiBJJ20gdGFsa2lu ZyB0byBqb3VybmFsaXN0cyBJIGp1c3Qgc2F5ICJwcm9ncmFtbWVyIiBvciBzb21ldGhpbmcgbGlr ZSB0aGF0Lgo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLS0gTGludXMgVG9ydmFs ZHMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==