From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 9 Mar 2018 10:29:45 +0100 From: jacopo mondi To: Geert Uytterhoeven Cc: Jacopo Mondi , Archit Taneja , Andrzej Hajda , Laurent Pinchart , David Airlie , Simon Horman , Magnus Damm , Niklas =?utf-8?Q?S=C3=B6derlund?= , Sergei Shtylyov , Rob Herring , Mark Rutland , DRI Development , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Subject: Re: [PATCH 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder Message-ID: <20180309092945.GE14819@w540> References: <1520522643-11756-1-git-send-email-jacopo+renesas@jmondi.org> <1520522643-11756-2-git-send-email-jacopo+renesas@jmondi.org> <20180309090422.GD14819@w540> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: devicetree-owner@vger.kernel.org List-ID: Hi Geert, On Fri, Mar 09, 2018 at 10:22:39AM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Fri, Mar 9, 2018 at 10:04 AM, jacopo mondi wrote: > > On Fri, Mar 09, 2018 at 09:10:55AM +0100, Geert Uytterhoeven wrote: > >> On Thu, Mar 8, 2018 at 4:24 PM, Jacopo Mondi wrote: > >> > Document Thine THC63LVD1024 LVDS decoder. > >> > > >> > Signed-off-by: Jacopo Mondi > >> > >> Thanks for your patch! > >> > >> > --- /dev/null > >> > +++ b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > >> > @@ -0,0 +1,59 @@ > >> > +THine Electronics THC63LVD1024 LVDS receiver > >> > >> Thine > >> > >> > +-------------------------------------------- > >> > + > >> > +The THC63LVD1024 is an LVDS receiver designed to convert multiple LVDS streams > >> > +to digital CMOS/TTL parallel data. > >> > + > >> > +Required properties: > >> > +- compatible: Shall be one of the following: > >> > + "thine,thc63lvd1024", > >> > + "lvds-decoder" > >> > >> What's the purpose of the second compatible value? > >> When should it be used? > > > > It is probably my bad having started with a generic LVDS decoder in > > mind and having then added properties specific to THC63LVD1024 to the > > driver and its bindings. > > > > "lvds,decoder" can be used when the chip is completely transparent to > > the SoC and none of the optional properties I have described in the > > bindings are specified (a generic "power-gpios" apart, see Andrzej > > comments on "pwdn-gpios" property). > > > > Also, I should make the driver behavior depend on the matched compatible > > string. When "lvds-decoder" is matched, it will just look for an > > optional power down gpio, when "thc63lvd1024" is matched, all of its > > Vcc supplies, pwdn gpio and oe gpios will be queried and, if present, > > eventually used in enable/disable routines. > > > > I'm just not sure how to describe that in bindings. Would something > > like the following work? > > > > Optional properties for "lvds,decoder" > > "lvds-decoder"? > Yes, sorry > > - power-gpios: Power control GPIOs > > > > Optional properties for "thine,thc63lvd1024" > > - pwdn-gpios: ... > > - oe-gpios: ... > > - supply-vcc: ... > > - supply-cvcc: ... > > - supply-pvcc: ... > > - supply-lvcc: ... > > Sounds like you need a (separate) generic lvds-decoder DT bindings document, > which you can extend/refer to from the THC63LVD1024-specific bindings. Ok, I'll go with two bindings document then and see how it looks. Thanks j > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: jacopo mondi Subject: Re: [PATCH 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder Date: Fri, 9 Mar 2018 10:29:45 +0100 Message-ID: <20180309092945.GE14819@w540> References: <1520522643-11756-1-git-send-email-jacopo+renesas@jmondi.org> <1520522643-11756-2-git-send-email-jacopo+renesas@jmondi.org> <20180309090422.GD14819@w540> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Geert Uytterhoeven Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sergei Shtylyov , David Airlie , DRI Development , Magnus Damm , Linux Kernel Mailing List , Rob Herring , Linux-Renesas , Simon Horman , Jacopo Mondi , Laurent Pinchart , Niklas =?utf-8?Q?S=C3=B6derlund?= List-Id: devicetree@vger.kernel.org SGkgR2VlcnQsCgpPbiBGcmksIE1hciAwOSwgMjAxOCBhdCAxMDoyMjozOUFNICswMTAwLCBHZWVy dCBVeXR0ZXJob2V2ZW4gd3JvdGU6Cj4gSGkgSmFjb3BvLAo+Cj4gT24gRnJpLCBNYXIgOSwgMjAx OCBhdCAxMDowNCBBTSwgamFjb3BvIG1vbmRpIDxqYWNvcG9Aam1vbmRpLm9yZz4gd3JvdGU6Cj4g PiBPbiBGcmksIE1hciAwOSwgMjAxOCBhdCAwOToxMDo1NUFNICswMTAwLCBHZWVydCBVeXR0ZXJo b2V2ZW4gd3JvdGU6Cj4gPj4gT24gVGh1LCBNYXIgOCwgMjAxOCBhdCA0OjI0IFBNLCBKYWNvcG8g TW9uZGkgPGphY29wbytyZW5lc2FzQGptb25kaS5vcmc+IHdyb3RlOgo+ID4+ID4gRG9jdW1lbnQg VGhpbmUgVEhDNjNMVkQxMDI0IExWRFMgZGVjb2Rlci4KPiA+PiA+Cj4gPj4gPiBTaWduZWQtb2Zm LWJ5OiBKYWNvcG8gTW9uZGkgPGphY29wbytyZW5lc2FzQGptb25kaS5vcmc+Cj4gPj4KPiA+PiBU aGFua3MgZm9yIHlvdXIgcGF0Y2ghCj4gPj4KPiA+PiA+IC0tLSAvZGV2L251bGwKPiA+PiA+ICsr KyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS90aGlu ZSx0aGM2M2x2ZDEwMjQudHh0Cj4gPj4gPiBAQCAtMCwwICsxLDU5IEBACj4gPj4gPiArVEhpbmUg RWxlY3Ryb25pY3MgVEhDNjNMVkQxMDI0IExWRFMgcmVjZWl2ZXIKPiA+Pgo+ID4+IFRoaW5lCj4g Pj4KPiA+PiA+ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ ID4+ID4gKwo+ID4+ID4gK1RoZSBUSEM2M0xWRDEwMjQgaXMgYW4gTFZEUyByZWNlaXZlciBkZXNp Z25lZCB0byBjb252ZXJ0IG11bHRpcGxlIExWRFMgc3RyZWFtcwo+ID4+ID4gK3RvIGRpZ2l0YWwg Q01PUy9UVEwgcGFyYWxsZWwgZGF0YS4KPiA+PiA+ICsKPiA+PiA+ICtSZXF1aXJlZCBwcm9wZXJ0 aWVzOgo+ID4+ID4gKy0gY29tcGF0aWJsZTogU2hhbGwgYmUgb25lIG9mIHRoZSBmb2xsb3dpbmc6 Cj4gPj4gPiArICAidGhpbmUsdGhjNjNsdmQxMDI0IiwKPiA+PiA+ICsgICJsdmRzLWRlY29kZXIi Cj4gPj4KPiA+PiBXaGF0J3MgdGhlIHB1cnBvc2Ugb2YgdGhlIHNlY29uZCBjb21wYXRpYmxlIHZh bHVlPwo+ID4+IFdoZW4gc2hvdWxkIGl0IGJlIHVzZWQ/Cj4gPgo+ID4gSXQgaXMgcHJvYmFibHkg bXkgYmFkIGhhdmluZyBzdGFydGVkIHdpdGggYSBnZW5lcmljIExWRFMgZGVjb2RlciBpbgo+ID4g bWluZCBhbmQgaGF2aW5nIHRoZW4gYWRkZWQgcHJvcGVydGllcyBzcGVjaWZpYyB0byBUSEM2M0xW RDEwMjQgdG8gdGhlCj4gPiBkcml2ZXIgYW5kIGl0cyBiaW5kaW5ncy4KPiA+Cj4gPiAibHZkcyxk ZWNvZGVyIiBjYW4gYmUgdXNlZCB3aGVuIHRoZSBjaGlwIGlzIGNvbXBsZXRlbHkgdHJhbnNwYXJl bnQgdG8KPiA+IHRoZSBTb0MgYW5kIG5vbmUgb2YgdGhlIG9wdGlvbmFsIHByb3BlcnRpZXMgSSBo YXZlIGRlc2NyaWJlZCBpbiB0aGUKPiA+IGJpbmRpbmdzIGFyZSBzcGVjaWZpZWQgKGEgZ2VuZXJp YyAicG93ZXItZ3Bpb3MiIGFwYXJ0LCBzZWUgQW5kcnplago+ID4gY29tbWVudHMgb24gInB3ZG4t Z3Bpb3MiIHByb3BlcnR5KS4KPiA+Cj4gPiBBbHNvLCBJIHNob3VsZCBtYWtlIHRoZSBkcml2ZXIg YmVoYXZpb3IgZGVwZW5kIG9uIHRoZSBtYXRjaGVkIGNvbXBhdGlibGUKPiA+IHN0cmluZy4gV2hl biAibHZkcy1kZWNvZGVyIiBpcyBtYXRjaGVkLCBpdCB3aWxsIGp1c3QgbG9vayBmb3IgYW4KPiA+ IG9wdGlvbmFsIHBvd2VyIGRvd24gZ3Bpbywgd2hlbiAidGhjNjNsdmQxMDI0IiBpcyBtYXRjaGVk LCBhbGwgb2YgaXRzCj4gPiBWY2Mgc3VwcGxpZXMsIHB3ZG4gZ3BpbyBhbmQgb2UgZ3Bpb3Mgd2ls bCBiZSBxdWVyaWVkIGFuZCwgaWYgcHJlc2VudCwKPiA+IGV2ZW50dWFsbHkgdXNlZCBpbiBlbmFi bGUvZGlzYWJsZSByb3V0aW5lcy4KPiA+Cj4gPiBJJ20ganVzdCBub3Qgc3VyZSBob3cgdG8gZGVz Y3JpYmUgdGhhdCBpbiBiaW5kaW5ncy4gV291bGQgc29tZXRoaW5nCj4gPiBsaWtlIHRoZSBmb2xs b3dpbmcgd29yaz8KPiA+Cj4gPiBPcHRpb25hbCBwcm9wZXJ0aWVzIGZvciAibHZkcyxkZWNvZGVy Igo+Cj4gImx2ZHMtZGVjb2RlciI/Cj4KClllcywgc29ycnkKCj4gPiAtIHBvd2VyLWdwaW9zOiBQ b3dlciBjb250cm9sIEdQSU9zCj4gPgo+ID4gT3B0aW9uYWwgcHJvcGVydGllcyBmb3IgInRoaW5l LHRoYzYzbHZkMTAyNCIKPiA+IC0gcHdkbi1ncGlvczogLi4uCj4gPiAtIG9lLWdwaW9zOiAuLi4K PiA+IC0gc3VwcGx5LXZjYzogLi4uCj4gPiAtIHN1cHBseS1jdmNjOiAuLi4KPiA+IC0gc3VwcGx5 LXB2Y2M6IC4uLgo+ID4gLSBzdXBwbHktbHZjYzogLi4uCj4KPiBTb3VuZHMgbGlrZSB5b3UgbmVl ZCBhIChzZXBhcmF0ZSkgZ2VuZXJpYyBsdmRzLWRlY29kZXIgRFQgYmluZGluZ3MgZG9jdW1lbnQs Cj4gd2hpY2ggeW91IGNhbiBleHRlbmQvcmVmZXIgdG8gZnJvbSB0aGUgVEhDNjNMVkQxMDI0LXNw ZWNpZmljIGJpbmRpbmdzLgoKT2ssIEknbGwgZ28gd2l0aCB0d28gYmluZGluZ3MgZG9jdW1lbnQg dGhlbiBhbmQgc2VlIGhvdyBpdCBsb29rcy4KClRoYW5rcwogICBqCgoKCj4KPiBHcntvZXRqZSxl ZXRpbmd9cywKPgo+ICAgICAgICAgICAgICAgICAgICAgICAgIEdlZXJ0Cj4KPiAtLQo+IEdlZXJ0 IFV5dHRlcmhvZXZlbiAtLSBUaGVyZSdzIGxvdHMgb2YgTGludXggYmV5b25kIGlhMzIgLS0gZ2Vl cnRAbGludXgtbTY4ay5vcmcKPgo+IEluIHBlcnNvbmFsIGNvbnZlcnNhdGlvbnMgd2l0aCB0ZWNo bmljYWwgcGVvcGxlLCBJIGNhbGwgbXlzZWxmIGEgaGFja2VyLiBCdXQKPiB3aGVuIEknbSB0YWxr aW5nIHRvIGpvdXJuYWxpc3RzIEkganVzdCBzYXkgInByb2dyYW1tZXIiIG9yIHNvbWV0aGluZyBs aWtlIHRoYXQuCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtLSBMaW51cyBUb3J2 YWxkcwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK