From: Cornelia Huck <cohuck@redhat.com>
To: Pierre Morel <pmorel@linux.vnet.ibm.com>
Cc: Nia Alarie <nia.alarie@gmail.com>,
qemu-devel@nongnu.org, jim@groklearning.com, stefanha@gmail.com,
borntraeger@de.ibm.com, qemu-s390x@nongnu.org, joel@jms.id.au
Subject: Re: [Qemu-devel] [PATCH] s390x/virtio: Convert virtio-ccw from *_exit to *_unrealize
Date: Fri, 9 Mar 2018 11:27:03 +0100 [thread overview]
Message-ID: <20180309112703.5edfb386.cohuck@redhat.com> (raw)
In-Reply-To: <9fdc51f3-edcb-1811-2501-da1e17e52c97@linux.vnet.ibm.com>
On Fri, 9 Mar 2018 10:23:31 +0100
Pierre Morel <pmorel@linux.vnet.ibm.com> wrote:
> On 07/03/2018 17:29, Nia Alarie wrote:
> > Signed-off-by: Nia Alarie <nia.alarie@gmail.com>
>
> What you do seems right to me, naming seems more logical, but can you
> please
> add a little commit message explaining why you change the interface?
I had asked Nia to do this; see the comments in qdev-core.h regarding
usage of exit vs. unrealize.
(I have already queued this for a pull request, since I'll be out
starting tomorrow.)
>
> Thanks,
>
> Pierre
>
> > ---
> > hw/s390x/virtio-ccw.c | 34 +++++++++++++++++-----------------
> > hw/s390x/virtio-ccw.h | 2 +-
> > 2 files changed, 18 insertions(+), 18 deletions(-)
next prev parent reply other threads:[~2018-03-09 10:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 16:29 [Qemu-devel] [PATCH] s390x/virtio: Convert virtio-ccw from *_exit to *_unrealize Nia Alarie
2018-03-08 15:20 ` Cornelia Huck
2018-03-08 16:13 ` Stefan Hajnoczi
2018-03-08 19:24 ` nee
2018-03-09 9:23 ` Pierre Morel
2018-03-09 10:27 ` Cornelia Huck [this message]
2018-03-09 11:28 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180309112703.5edfb386.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=jim@groklearning.com \
--cc=joel@jms.id.au \
--cc=nia.alarie@gmail.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.