All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] mallocstress: extend test time on arm
Date: Fri, 9 Mar 2018 13:04:14 +0100	[thread overview]
Message-ID: <20180309120414.GD24656@rei> (raw)
In-Reply-To: <2012939043.6317537.1520592935484.JavaMail.zimbra@redhat.com>

Hi!
> Just wanted to go with minimal impact on other arches (since they worked
> OK so far as I'm aware). I don't have strong opinion either way,
> I can make the timeout unconditional.

Given that the test seems to take 4m on successful run 5m timeout seems
to be a bit too strict to me. We are not primarily benchmarking the
kernel, so these timeouts are better to be set to be double of the
expecte runtime.

Also I like to avoid #ifdefs whenever possible.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2018-03-09 12:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-09 10:01 [LTP] [PATCH] mallocstress: extend test time on arm Jan Stancek
2018-03-09 10:41 ` Cyril Hrubis
2018-03-09 10:55   ` Jan Stancek
2018-03-09 12:04     ` Cyril Hrubis [this message]
2018-03-09 12:14       ` Jan Stancek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180309120414.GD24656@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.