All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Ian Jackson <ian.jackson@citrix.com>
Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org,
	Ross Lagerwall <ross.lagerwall@citrix.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post
Date: Fri, 9 Mar 2018 09:55:57 -0300	[thread overview]
Message-ID: <20180309125557.GH3417@localhost.localdomain> (raw)
In-Reply-To: <23202.28943.344150.512881@mariner.uk.xensource.com>

On Fri, Mar 09, 2018 at 11:33:35AM +0000, Ian Jackson wrote:
> Eduardo Habkost writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post"):
> > On Thu, Mar 08, 2018 at 05:39:09PM +0000, Ian Jackson wrote:
> > [...]
> > > diff --git a/vl.c b/vl.c
> > > +    xen_setup_post();
> > 
> > I don't think we should have accelerator-specific code in main(),
> > if we already have accelerator classes that can abstract that
> > out.  I suggest adding a AccelClass;:setup_post() method that can
> > be called here.
> 
> I think I can do that.
> 
> Although, it is a bit disappointing to be given this feedback in v6 of
> this series.  Did the right people not get CC'd on v5 in October ?

That is entirely my fault, for not paying attention to the patch
back in october (I was CCed on it).  Sorry for that.

-- 
Eduardo

  parent reply	other threads:[~2018-03-09 12:56 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08 17:39 [PATCH v6 00/11] xen: xen-domid-restrict improvements Ian Jackson
2018-03-08 17:39 ` [Qemu-devel] " Ian Jackson
2018-03-08 17:39 ` [PATCH 01/11] xen: link against xentoolcore Ian Jackson
2018-03-08 17:39   ` [Qemu-devel] " Ian Jackson
2018-03-08 17:39 ` [PATCH 02/11] xen: restrict: use xentoolcore_restrict_all Ian Jackson
2018-03-08 17:39   ` [Qemu-devel] " Ian Jackson
2018-03-08 17:39 ` [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post Ian Jackson
2018-03-08 17:39   ` [Qemu-devel] " Ian Jackson
2018-03-08 20:03   ` Eduardo Habkost
2018-03-08 20:03     ` [Qemu-devel] " Eduardo Habkost
2018-03-09 11:33     ` Ian Jackson
2018-03-09 11:33       ` [Qemu-devel] " Ian Jackson
2018-03-09 12:07       ` Ian Jackson
2018-03-09 12:08         ` Ian Jackson
2018-03-09 12:08           ` [Qemu-devel] " Ian Jackson
2018-03-09 12:09           ` Ian Jackson
2018-03-09 12:09             ` [Qemu-devel] " Ian Jackson
2018-03-09 12:58         ` Eduardo Habkost
2018-03-09 12:58           ` [Qemu-devel] " Eduardo Habkost
2018-03-11 21:12           ` Stefano Stabellini
2018-03-11 21:12           ` [Qemu-devel] " Stefano Stabellini
2018-03-09 12:07       ` Ian Jackson
2018-03-09 12:55       ` Eduardo Habkost [this message]
2018-03-09 12:55       ` Eduardo Habkost
2018-03-08 17:39 ` [Qemu-devel] [PATCH 04/11] xen: destroy_hvm_domain: Move reason into a variable Ian Jackson
2018-03-08 17:39 ` Ian Jackson
2018-03-08 17:39 ` [PATCH 05/11] xen: move xc_interface compatibility fallback further up the file Ian Jackson
2018-03-08 17:39   ` [Qemu-devel] " Ian Jackson
2018-03-08 17:39 ` [PATCH 06/11] xen: destroy_hvm_domain: Try xendevicemodel_shutdown Ian Jackson
2018-03-08 17:39   ` [Qemu-devel] " Ian Jackson
2018-03-08 17:39 ` [PATCH 07/11] os-posix: Provide new -runas <uid>:<gid> facility Ian Jackson
2018-03-08 17:39   ` [Qemu-devel] " Ian Jackson
2018-03-08 17:39 ` [Qemu-devel] [PATCH 08/11] configure: do_compiler: Dump some extra info under bash Ian Jackson
2018-03-08 17:39 ` Ian Jackson
2018-03-08 17:39 ` [PATCH 09/11] xen: Use newly added dmops for mapping VGA memory Ian Jackson
2018-03-08 17:39   ` [Qemu-devel] " Ian Jackson
2018-03-08 17:39 ` [PATCH 10/11] xen: Expect xenstore write to fail when restricted Ian Jackson
2018-03-08 17:39   ` [Qemu-devel] " Ian Jackson
2018-03-08 17:39 ` [PATCH 11/11] scripts/get_maintainer.pl: Print proper error message for missing $file Ian Jackson
2018-03-08 17:39   ` [Qemu-devel] " Ian Jackson
2018-03-08 17:45 ` [PATCH v6 00/11] xen: xen-domid-restrict improvements Ian Jackson
2018-03-08 17:45   ` [Qemu-devel] " Ian Jackson
2018-03-08 17:54 ` no-reply
2018-03-08 17:54   ` no-reply
2018-03-08 17:58   ` Ian Jackson
2018-03-08 17:58     ` Ian Jackson
2018-03-08 18:10 ` no-reply
2018-03-08 18:10   ` no-reply
2018-03-08 20:00 ` no-reply
2018-03-08 20:00   ` no-reply
2018-03-08 21:45 ` no-reply
2018-03-08 21:45   ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180309125557.GH3417@localhost.localdomain \
    --to=ehabkost@redhat.com \
    --cc=anthony.perard@citrix.com \
    --cc=ian.jackson@citrix.com \
    --cc=jgross@suse.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ross.lagerwall@citrix.com \
    --cc=rth@twiddle.net \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.