From: Olaf Hering <olaf@aepfle.de>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH v1] x86/domctl: remove impossible condition in XEN_DOMCTL_getpageframeinfo3
Date: Fri, 9 Mar 2018 17:09:37 +0100 [thread overview]
Message-ID: <20180309160937.GE12975@aepfle.de> (raw)
In-Reply-To: <35524832-2900-6a73-8bf3-1d6a5d92783b@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 435 bytes --]
On Fri, Mar 09, Andrew Cooper wrote:
> On 09/03/18 16:01, Olaf Hering wrote:
> > The value of num is always the same as domctl->u.getpageframeinfo3.num,
> > it was assigned just a few lines before.
> >
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> This isn't dead code. It is a truncation check.
How can this happen, other than num being a 32bit type?
Perhaps the type of num should match the type of i?
Olaf
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-03-09 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 16:01 [PATCH v1] x86/domctl: remove impossible condition in XEN_DOMCTL_getpageframeinfo3 Olaf Hering
2018-03-09 16:02 ` Andrew Cooper
2018-03-09 16:09 ` Olaf Hering [this message]
2018-03-09 16:07 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180309160937.GE12975@aepfle.de \
--to=olaf@aepfle.de \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.