From: "Emilio G. Cota" <cota@braap.org>
To: Michael Clark <mjc@sifive.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Stefan O'Rear <sorear2@gmail.com>,
Richard Henderson <richard.henderson@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Apparently fpu/softfloat.c:1374 is reachable
Date: Fri, 9 Mar 2018 16:49:57 -0500 [thread overview]
Message-ID: <20180309214957.GA32140@flamenco> (raw)
In-Reply-To: <CAHNT7NtLVFU08oC0ReduK-2mFBwgwjvgfEWaZpYFY-GkjKWv=g@mail.gmail.com>
On Fri, Mar 09, 2018 at 11:34:56 +0000, Michael Clark wrote:
> BTW how does one hide signed-off-by or cc email addresses with the
> git-send-email workflow?
You just don't.
> Seems like editing the patch after git format-patch is likely the only way
> around for contributors whose wishes I might not have honoured, except
> originally when I was using an advoc albeit buggy workflow, where the Cc’s
> et all we’re later added to the patch headers and not the commits. I’ve
> probably inadvertently violated someone’s wish to keep their email address
> out of the list archives, which is an understandable wish.
If that's their wish I'd say just use the --cc flag; they get to keep
their address hidden from public commit messages, at the expense of (possibly)
being Cc'ed on more emails than they need to. I think it's a
reasonable trade-off.
That said, if they really want to hide their address from others,
you should use --bcc. But then they wouldn't receive the replies.
> This is not an issue with GitHub PR’s as they keep identity information
> differently however slicing up the port for upstreaming has lost some of
> our contributor history. I have made tags before every squash and rebase so
> we can find all history in the riscv repo, as well as previously trying to
> keep personal emails out of the cover letters in the first series. With the
> change to the git-sendemail workflow i’ve likely regressed here.
>
> I also probably have to manually edit patches to add ‘Cc to the
> riscv-patches mailing list, as it doesn’t seem right to put that email in
> the commit messages.
Isn't Cc'ing riscv-patches an obvious use case for using the --cc flag?
(BTW You can add as many --cc's as you want, and these apply to all patches
in a series.)
E.
PS. As always, remember to use --dry-run =)
next prev parent reply other threads:[~2018-03-09 21:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 4:22 [Qemu-devel] Apparently fpu/softfloat.c:1374 is reachable Michael Clark
2018-03-09 10:44 ` Peter Maydell
2018-03-09 11:17 ` Michael Clark
2018-03-09 11:29 ` Philippe Mathieu-Daudé
2018-03-09 11:56 ` Michael Clark
2018-03-09 12:09 ` [Qemu-devel] Apparently fpu/softfloat.c:1374 is reachable (-> binary images) Liviu Ionescu
2018-03-09 13:20 ` [Qemu-devel] Apparently fpu/softfloat.c:1374 is reachable Michael Clark
2018-03-09 11:34 ` Michael Clark
2018-03-09 21:49 ` Emilio G. Cota [this message]
2018-03-09 22:31 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180309214957.GA32140@flamenco \
--to=cota@braap.org \
--cc=mjc@sifive.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sorear2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.