All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: David Veenstra <davidjulianveenstra@gmail.com>
Cc: lars@metafoo.de, linux-iio@vger.kernel.org
Subject: Re: [PATCH] Staging: iio: adt7316: Move symbol export to definition
Date: Sat, 10 Mar 2018 15:19:33 +0000	[thread overview]
Message-ID: <20180310151933.76fe3ac9@archlinux> (raw)
In-Reply-To: <20180308094729.GA11441@zenbook-arch>

On Thu, 8 Mar 2018 10:47:29 +0100
David Veenstra <davidjulianveenstra@gmail.com> wrote:

> This patch clears the following checkpatch.pl warning:
> 
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> +EXPORT_SYMBOL_GPL(adt7316_pm_ops);
> 
> Signed-off-by: David Veenstra <davidjulianveenstra@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/staging/iio/addac/adt7316.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 2d33632c00e8..3f22d1088713 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -2079,9 +2079,8 @@ static int adt7316_enable(struct device *dev)
>  
>  	return _adt7316_store_enabled(chip, 1);
>  }
> -
> -SIMPLE_DEV_PM_OPS(adt7316_pm_ops, adt7316_disable, adt7316_enable);
>  EXPORT_SYMBOL_GPL(adt7316_pm_ops);
> +SIMPLE_DEV_PM_OPS(adt7316_pm_ops, adt7316_disable, adt7316_enable);
>  #endif
>  
>  static const struct iio_info adt7316_info = {


      reply	other threads:[~2018-03-10 15:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08  9:47 [PATCH] Staging: iio: adt7316: Move symbol export to definition David Veenstra
2018-03-10 15:19 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180310151933.76fe3ac9@archlinux \
    --to=jic23@jic23.retrosnub.co.uk \
    --cc=davidjulianveenstra@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.