Re: [PATCH Netfilter] net: netfilter: Replace printk() with more standardize output format.

[Florian Westphal <fw@strlen.de>]

Arushi Singhal <arushisinghal19971997@gmail.com> wrote:
> I''ll resend the patch according your suggestions.
> 
> Just for curiosity wanted to ask why not netdev_*().

netfilter is not a network driver.

> > >               register_net_sysctl(net, "net/netfilter", table);
> > >       if (!net->ct.event_sysctl_header) {
> > > -             printk(KERN_ERR "nf_ct_event: can't register to
> > sysctl.\n");
> > > +             netdev_err(net->loopback_dev, "nf_ct_event: can't register
> > to sysctl.\n");

This claims that the error is related to loopback device.  Its not.

> > >                       if (!nskb) {
> > > -                             printk(KERN_WARNING "nf_queue: OOM "
> > > -                                   "in mangle, dropping packet\n");
> > > +                             netdev_warn(nskb->dev, "nf_queue: OOM "
> > > +                                         "in mangle, dropping

This now points at a random network device, but again
this condition doesn't have anything to do with a network device.