Re: [Qemu-devel] [PATCH 6/6] qemu-iotests: Test luks QMP image creation

["Daniel P. Berrangé" <berrange@redhat.com>]

On Fri, Mar 09, 2018 at 06:27:13PM +0100, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  tests/qemu-iotests/208       | 211 +++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/208.out   | 136 ++++++++++++++++++++++++++++
>  tests/qemu-iotests/common.rc |   2 +-
>  tests/qemu-iotests/group     |   1 +
>  4 files changed, 349 insertions(+), 1 deletion(-)
>  create mode 100755 tests/qemu-iotests/208
>  create mode 100644 tests/qemu-iotests/208.out
> 
> diff --git a/tests/qemu-iotests/208 b/tests/qemu-iotests/208
> new file mode 100755
> index 0000000000..ab4650d0ae
> --- /dev/null
> +++ b/tests/qemu-iotests/208


> +
> +run_qemu -object secret,id=keysec0,data="foo" <<EOF
> +{ "execute": "qmp_capabilities" }
> +{ "execute": "x-blockdev-create",
> +  "arguments": {
> +      "driver": "file",
> +      "filename": "$TEST_IMG_FILE",
> +      "size": 0
> +  }
> +}
> +{ "execute": "x-blockdev-create",
> +  "arguments": {
> +      "driver": "$IMGFMT",
> +      "file": {
> +          "driver": "file",
> +          "filename": "$TEST_IMG_FILE"
> +      },
> +      "size": $size,
> +      "qcrypto": {
> +          "key-secret": "keysec0",
> +          "cipher-alg": "twofish-128",
> +          "cipher-mode": "ctr",
> +          "ivgen-alg": "plain64",
> +          "ivgen-hash-alg": "md5",
> +          "hash-alg": "sha1",
> +          "iter-time": 10

I'd recommend using  'iter-time': 10, in every single x-blockdev-create
command in this file, otherwise this test will be unneccessarily slow to
execute as each x-blockdev-create will burn 2 seconds of time.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|