From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: dm-devel@redhat.com, Mikulas Patocka <mpatocka@redhat.com>,
Thomas Jaskiewicz <tomj@permabit.com>
Subject: Re: dm-bufio: move dm-bufio.h to include/linux/
Date: Mon, 12 Mar 2018 11:57:13 -0400 [thread overview]
Message-ID: <20180312155712.GB29395@redhat.com> (raw)
In-Reply-To: <20180312074827.GA30695@infradead.org>
On Mon, Mar 12 2018 at 3:48am -0400,
Christoph Hellwig <hch@infradead.org> wrote:
> On Thu, Mar 08, 2018 at 03:36:21PM -0500, Mike Snitzer wrote:
> > While I appreciate your interest in what constitutes a reasonable change
> > for DM, why are you so emphatic about disallowing out-of-tree DM modules
> > from using dm-bufio?
>
> Because I'd rather get them into the tree than providing escapes just
> for them.
This isn't about providing an escape.
It may be unintuitive, or you may not believe me, but as I said in my
previous email this change encourages out of tree DM targets to use
dm-bufio rather than invent their own equivalent. It is very useful to
me (speaking as the sucker who has to shepherd DM targets upstream) for
others to get that code path right, without reinventing it, rather than
have to disruptively change the target to use dm-bufio (where it makes
sense) prior to submission for upstream inclusion.
For DM targets that are extremely complex, external use of dm-bufio vs
not is the tail wagging the dog. There are like 50+ other things that
need work in addition to using dm-bufio. But every code transformation
hurdle to upstream inclusion that can be done out of tree will help the
DM target be more stable upon upstream inclusion.
Mike
next prev parent reply other threads:[~2018-03-12 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 9:22 [PATCH] dm-bufio: move dm-bufio.h to include/linux/ Mikulas Patocka
2018-03-08 14:49 ` Christoph Hellwig
2018-03-08 20:36 ` Mike Snitzer
2018-03-12 7:48 ` Christoph Hellwig
2018-03-12 15:57 ` Mike Snitzer [this message]
2018-03-09 3:56 ` [PATCH] " Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312155712.GB29395@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=mpatocka@redhat.com \
--cc=tomj@permabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.