All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 3/5] tests/kms_frontbuffer_tracking: Fix basic subtest
Date: Mon, 12 Mar 2018 18:30:11 +0100	[thread overview]
Message-ID: <20180312173013.50903-4-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20180312173013.50903-1-maarten.lankhorst@linux.intel.com>

When running the entire binary, we have touched features before running
the basic subtest. Restore them back to the defaults.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_frontbuffer_tracking.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 746f8d1f8a75..000f54eef408 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -1218,9 +1218,6 @@ static void unset_all_crtcs(void)
 
 static void disable_features(const struct test_mode *t)
 {
-	if (t->feature == FEATURE_DEFAULT)
-		return;
-
 	fbc_set(0);
 	psr_set(0);
 	drrs_set(0);
@@ -1849,8 +1846,12 @@ static void set_region_for_test(const struct test_mode *t,
 
 static void enable_features_for_test(const struct test_mode *t)
 {
-	if (t->feature == FEATURE_DEFAULT)
+	if (t->feature == FEATURE_DEFAULT) {
+		fbc_set(-1);
+		psr_set(-1);
+		drrs_set(-1);
 		return;
+	}
 
 	if (t->feature & FEATURE_FBC)
 		fbc_set(1);
-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2018-03-12 17:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12 17:30 [igt-dev] [PATCH i-g-t 0/5] tests/kms_frontbuffer_tracking: Rework to prevent modesets! Maarten Lankhorst
2018-03-12 17:30 ` [igt-dev] [PATCH i-g-t 1/5] lib/igt_aux: Add igt_get_module_param_int Maarten Lankhorst
2018-03-14 14:00   ` Chris Wilson
2018-03-12 17:30 ` [igt-dev] [PATCH i-g-t 2/5] tests/kms_frontbuffer_tracking: Rework toggling drrs/fbc/psr Maarten Lankhorst
2018-03-12 17:30 ` Maarten Lankhorst [this message]
2018-03-12 17:30 ` [igt-dev] [PATCH i-g-t 4/5] tests/kms_frontbuffer_tracking: Add support for toggling edp psr through debugfs Maarten Lankhorst
2018-03-12 17:30 ` [igt-dev] [PATCH i-g-t 5/5] tests/kms_frontbuffer_tracking: Remove redundant modesets during subtest start, v2 Maarten Lankhorst
2018-03-12 23:51 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Rework to prevent modesets! Patchwork
2018-03-13  5:02 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180312173013.50903-4-maarten.lankhorst@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.