From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5 Date: Mon, 12 Mar 2018 16:33:11 -0700 Message-ID: <20180312233311.GA3848@localhost.localdomain> References: <4716007c23abeb0e42015786794539454aff487b.1520886814.git.dvhart@infradead.org> <20180312202319.GA88572@localhost.localdomain> <20180312220751.GA1757@light.dominikbrodowski.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Torvalds Cc: Dominik Brodowski , Mario Limonciello , platform-driver-x86@vger.kernel.org, Linux Kernel Mailing List , Andy Shevchenko List-Id: platform-driver-x86.vger.kernel.org On Mon, Mar 12, 2018 at 03:17:57PM -0700, Linus Torvalds wrote: > On Mon, Mar 12, 2018 at 3:07 PM, Dominik Brodowski > wrote: > > > > I'm awfully sorry, but this patch doesn't solve the issue. > > CONFIG_ACPI_WMI=y was/is set, but still enabling CONFIG_DELL_SMBIOS_WMI=y > > causes a very-early crash of v4.16-rc5. In fact, so early that the normal > > boot messages never show up on the screen... > > Hmm. My xps13 works fine, but it's the 9350 version so not the same machine. > > But it does sound like that commit 25d47027e10 ("platform/x86: > dell-smbios: Link all dell-smbios-* modules together") should just be > reverted. It has clearly caused a lot more pain than it fixed. Unfortunately, yes. This will re-instate the race condition it "fixed". I'll work with Mario to fix this properly in 4.17, preferably in a way that we can apply to stable. Pending an "oops, nevermind, the patch works" from Dominik by tomorrow morning, I'll submit the pull request to revert dell-smbios changes back to and including 25d47027e10. Apologies for the noise on this one Linus, it got away from me. -- Darren Hart VMware Open Source Technology Center