All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC] [PATCH] shell: ROD_SILENT: Print std{out, err} on failure
Date: Tue, 13 Mar 2018 14:30:49 +0100	[thread overview]
Message-ID: <20180313133049.GA21673@rei.lan> (raw)
In-Reply-To: <876060w2m5.fsf@rpws.prws.suse.cz>

Hi!
> >> LGTM except that you could maybe use ${ } instead of $( ) as a small
> >> optimisation.
> >
> > I do not get it either. Where should I put the ${} insetad of $()?
> 
> Sorry I was probably wrong, unless you can somehow change from variable
> substitution to redirecting from a group (that is {} > $var not
> var=${}).

So can I consider the original patch acked?

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2018-03-13 13:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 15:03 [LTP] [RFC] [PATCH] shell: ROD_SILENT: Print std{out, err} on failure Cyril Hrubis
2018-02-21  9:12 ` Richard Palethorpe
2018-02-22  4:05   ` Li Wang
2018-03-13 12:46   ` Cyril Hrubis
2018-03-13 13:01     ` Richard Palethorpe
2018-03-13 13:30       ` Cyril Hrubis [this message]
2018-03-13 15:16         ` Richard Palethorpe
2018-03-14 13:58           ` Cyril Hrubis
  -- strict thread matches above, loose matches on Subject: below --
2018-02-12 14:40 Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180313133049.GA21673@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.