From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Michel Dänzer" <michel@daenzer.net>
Cc: intel-gfx@lists.freedesktop.org,
Harry Wentland <harry.wentland@amd.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/3] drm: Add the optional .fb_modifier() hook
Date: Tue, 13 Mar 2018 17:12:15 +0200 [thread overview]
Message-ID: <20180313151215.GZ5453@intel.com> (raw)
In-Reply-To: <e08f90ae-abc7-b079-efa4-098e2afc5b92@daenzer.net>
On Tue, Mar 13, 2018 at 03:38:38PM +0100, Michel Dänzer wrote:
> On 2018-03-13 03:28 PM, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > To make it possible for the core to check the fb pixel format and
> > modifier, we need to first ask the driver to deduce the modifier
> > when the request does not explicitly specify one.
> >
> > Add a new .fb_modifier() hook for that purpose and convert i915
> > and vc4 to make use if it. All other drivers seem to currently
> > assume linear when the request does not specify anything else,
> > [...]
>
> That's not true at least for the amdgpu and radeon drivers. The tiling
> mode is communicated via BO metadata.
Well, at least those driver don't do any bo tiling->modifier conversion.
Radeon doesn't do modifiers I suppose, so that part is probably OK.
amggpu might just be broken, not sure.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-03-13 15:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 20:40 [PATCH 1/3] drm: Add the optional .fb_modifier() hook Ville Syrjala
2018-03-12 20:40 ` [PATCH 2/3] drm: Make sure at least one plane supports the fb format Ville Syrjala
2018-03-15 17:42 ` Eric Anholt
2018-03-15 17:48 ` Ville Syrjälä
2018-03-15 18:03 ` Ville Syrjälä
2018-03-15 18:48 ` Ville Syrjälä
2018-03-16 22:07 ` Eric Anholt
2018-03-12 20:40 ` [PATCH 3/3] drm/i915: Eliminate the horrendous format check code Ville Syrjala
2018-03-12 21:44 ` ✗ Fi.CI.BAT: failure for series starting with [1/3] drm: Add the optional .fb_modifier() hook Patchwork
2018-03-13 14:28 ` [PATCH v2 1/3] " Ville Syrjala
2018-03-13 14:38 ` Michel Dänzer
2018-03-13 15:12 ` Ville Syrjälä [this message]
2018-03-13 15:18 ` Michel Dänzer
2018-03-13 15:20 ` Daniel Vetter
2018-03-13 15:35 ` Michel Dänzer
2018-03-13 15:46 ` Ville Syrjälä
2018-03-13 16:06 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm: Add the optional .fb_modifier() hook (rev2) Patchwork
2018-03-13 16:56 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-03-13 17:03 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313151215.GZ5453@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.