From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/psr: Comment to clarify SRD_DEBUG is called PSR_MASK SKL+
Date: Tue, 13 Mar 2018 15:36:33 -0700 [thread overview]
Message-ID: <20180313223632.GB3945@intel.com> (raw)
In-Reply-To: <20180313222550.GG5970@intel.com>
On Tue, Mar 13, 2018 at 03:25:51PM -0700, Rodrigo Vivi wrote:
> On Mon, Mar 12, 2018 at 09:09:54PM -0700, Dhinakaran Pandiyan wrote:
> > What was called SRD_DEBUG(0x6F860) on HSW and BDW was renamed to PSR_MASK
> > SKL onwards, add a note next to the macro definition.
> > There is also a different PSR_DEBUG on SKL+ to add to the confusion.
> >
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>
> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
and pushed. thanks.
>
> > ---
> > drivers/gpu/drm/i915/i915_reg.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > index 23c0f9bdf591..e8a4b61397ba 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -4186,13 +4186,13 @@ enum {
> > #define EDP_PSR_PERF_CNT _MMIO(dev_priv->psr_mmio_base + 0x44)
> > #define EDP_PSR_PERF_CNT_MASK 0xffffff
> >
> > -#define EDP_PSR_DEBUG _MMIO(dev_priv->psr_mmio_base + 0x60)
> > +#define EDP_PSR_DEBUG _MMIO(dev_priv->psr_mmio_base + 0x60) /* PSR_MASK on SKL+ */
> > #define EDP_PSR_DEBUG_MASK_MAX_SLEEP (1<<28)
> > #define EDP_PSR_DEBUG_MASK_LPSP (1<<27)
> > #define EDP_PSR_DEBUG_MASK_MEMUP (1<<26)
> > #define EDP_PSR_DEBUG_MASK_HPD (1<<25)
> > #define EDP_PSR_DEBUG_MASK_DISP_REG_WRITE (1<<16)
> > -#define EDP_PSR_DEBUG_EXIT_ON_PIXEL_UNDERRUN (1<<15)
> > +#define EDP_PSR_DEBUG_EXIT_ON_PIXEL_UNDERRUN (1<<15) /* SKL+ */
> >
> > #define EDP_PSR2_CTL _MMIO(0x6f900)
> > #define EDP_PSR2_ENABLE (1<<31)
> > --
> > 2.14.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-03-13 22:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 4:09 [PATCH] drm/i915/psr: Comment to clarify SRD_DEBUG is called PSR_MASK SKL+ Dhinakaran Pandiyan
2018-03-13 4:46 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-13 8:00 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-03-13 22:25 ` [PATCH] " Rodrigo Vivi
2018-03-13 22:36 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313223632.GB3945@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.