From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:54930 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbeCNLtt (ORCPT ); Wed, 14 Mar 2018 07:49:49 -0400 Date: Wed, 14 Mar 2018 12:49:48 +0100 From: Greg KH To: Richard Leitner Cc: Richard Leitner , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, mathias.nyman@intel.com, bhelgaas@google.com Subject: Re: [PATCH 2/3] usb: host: pci: introduce PCI vendor ID for Netlogic Message-ID: <20180314114948.GA25368@kroah.com> References: <20180314102933.21367-1-dev@g0hl1n.net> <20180314102933.21367-3-dev@g0hl1n.net> <20180314104849.GB32615@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-pci-owner@vger.kernel.org List-ID: On Wed, Mar 14, 2018 at 12:36:17PM +0100, Richard Leitner wrote: > > On 03/14/2018 11:48 AM, Greg KH wrote: > > On Wed, Mar 14, 2018 at 11:29:32AM +0100, Richard Leitner wrote: > >> From: Richard Leitner > >> > >> Replace the hardcoded PCI vendor ID of Netlogic with a definition in > >> pci_ids.h > > > > Why? It's only being used in one file, so it should not be in > > pci_ids.h, right? > > It's also used as PCI_VENDOR_NETLOGIC in arch/mips/netlogic/xlp/. > > Should this be replaced with PCI_VENDOR_ID_NETLOGIC from pci_ids.h? Yes, if you are going to add it to pci_ids.h, it had better be used by multiple files, otherwise it does not belong in there. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [2/3] usb: host: pci: introduce PCI vendor ID for Netlogic From: Greg Kroah-Hartman Message-Id: <20180314114948.GA25368@kroah.com> Date: Wed, 14 Mar 2018 12:49:48 +0100 To: Richard Leitner Cc: Richard Leitner , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, mathias.nyman@intel.com, bhelgaas@google.com List-ID: T24gV2VkLCBNYXIgMTQsIDIwMTggYXQgMTI6MzY6MTdQTSArMDEwMCwgUmljaGFyZCBMZWl0bmVy IHdyb3RlOgo+IAo+IE9uIDAzLzE0LzIwMTggMTE6NDggQU0sIEdyZWcgS0ggd3JvdGU6Cj4gPiBP biBXZWQsIE1hciAxNCwgMjAxOCBhdCAxMToyOTozMkFNICswMTAwLCBSaWNoYXJkIExlaXRuZXIg d3JvdGU6Cj4gPj4gRnJvbTogUmljaGFyZCBMZWl0bmVyIDxyaWNoYXJkLmxlaXRuZXJAc2tpZGF0 YS5jb20+Cj4gPj4KPiA+PiBSZXBsYWNlIHRoZSBoYXJkY29kZWQgUENJIHZlbmRvciBJRCBvZiBO ZXRsb2dpYyB3aXRoIGEgZGVmaW5pdGlvbiBpbgo+ID4+IHBjaV9pZHMuaAo+ID4gCj4gPiBXaHk/ ICBJdCdzIG9ubHkgYmVpbmcgdXNlZCBpbiBvbmUgZmlsZSwgc28gaXQgc2hvdWxkIG5vdCBiZSBp bgo+ID4gcGNpX2lkcy5oLCByaWdodD8KPiAKPiBJdCdzIGFsc28gdXNlZCBhcyBQQ0lfVkVORE9S X05FVExPR0lDIGluIGFyY2gvbWlwcy9uZXRsb2dpYy94bHAvLgo+IAo+IFNob3VsZCB0aGlzIGJl IHJlcGxhY2VkIHdpdGggUENJX1ZFTkRPUl9JRF9ORVRMT0dJQyBmcm9tIHBjaV9pZHMuaD8KClll cywgaWYgeW91IGFyZSBnb2luZyB0byBhZGQgaXQgdG8gcGNpX2lkcy5oLCBpdCBoYWQgYmV0dGVy IGJlIHVzZWQgYnkKbXVsdGlwbGUgZmlsZXMsIG90aGVyd2lzZSBpdCBkb2VzIG5vdCBiZWxvbmcg aW4gdGhlcmUuCgp0aGFua3MsCgpncmVnIGstaAotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlz IGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkg b2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8g aW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg==