diff for duplicates of <20180314135321.GY27351@localhost.localdomain> diff --git a/a/1.txt b/N1/1.txt index fd1ee4e..962cd23 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -54,12 +54,12 @@ Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> > if (!found) > return -EINVAL; > -> + /* refcnt = 1 and !list_empty mean it's not being used anywhere +> + /* refcnt == 1 and !list_empty mean it's not being used anywhere > + * and deactivated will be set, so it's time to notify userland > + * that this shkey can be freed. > + */ > + if (asoc && !list_empty(&key->key_list) && -> + refcount_read(&key->refcnt) = 1) { +> + refcount_read(&key->refcnt) == 1) { > + struct sctp_ulpevent *ev; > + > + ev = sctp_ulpevent_make_authkey(asoc, key->key_id, @@ -84,12 +84,12 @@ Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> > + struct sctp_shared_key *shkey = chunk->shkey; > + struct sctp_association *asoc = chunk->asoc; > + -> + /* refcnt = 2 and !list_empty mean after this release, it's +> + /* refcnt == 2 and !list_empty mean after this release, it's > + * not being used anywhere, and it's time to notify userland > + * that this shkey can be freed if it's been deactivated. > + */ > + if (shkey->deactivated && !list_empty(&shkey->key_list) && -> + refcount_read(&shkey->refcnt) = 2) { +> + refcount_read(&shkey->refcnt) == 2) { > + struct sctp_ulpevent *ev; > + > + ev = sctp_ulpevent_make_authkey(asoc, shkey->key_id, @@ -128,12 +128,12 @@ Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> > + if (chunk->shkey) { > + struct sctp_shared_key *shkey = chunk->shkey; > + -> + /* refcnt = 2 and !list_empty mean after this release, it's +> + /* refcnt == 2 and !list_empty mean after this release, it's > + * not being used anywhere, and it's time to notify userland > + * that this shkey can be freed if it's been deactivated. > + */ > + if (shkey->deactivated && !list_empty(&shkey->key_list) && -> + refcount_read(&shkey->refcnt) = 2) { +> + refcount_read(&shkey->refcnt) == 2) { > + struct sctp_ulpevent *ev; > + > + ev = sctp_ulpevent_make_authkey(asoc, shkey->key_id, diff --git a/a/content_digest b/N1/content_digest index 564eb6d..6f17d0a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\022218ceee8900508e30833758b613173d02031eb.1521025473.git.lucien.xin@gmail.com\0" "From\0Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>\0" "Subject\0Re: [PATCH net-next 4/5] sctp: add SCTP_AUTH_FREE_KEY type for AUTHENTICATION_EVENT\0" - "Date\0Wed, 14 Mar 2018 13:53:21 +0000\0" + "Date\0Wed, 14 Mar 2018 10:53:21 -0300\0" "To\0Xin Long <lucien.xin@gmail.com>\0" "Cc\0network dev <netdev@vger.kernel.org>" linux-sctp@vger.kernel.org @@ -66,12 +66,12 @@ "> \tif (!found)\n" "> \t\treturn -EINVAL;\n" "> \n" - "> +\t/* refcnt = 1 and !list_empty mean it's not being used anywhere\n" + "> +\t/* refcnt == 1 and !list_empty mean it's not being used anywhere\n" "> +\t * and deactivated will be set, so it's time to notify userland\n" "> +\t * that this shkey can be freed.\n" "> +\t */\n" "> +\tif (asoc && !list_empty(&key->key_list) &&\n" - "> +\t refcount_read(&key->refcnt) = 1) {\n" + "> +\t refcount_read(&key->refcnt) == 1) {\n" "> +\t\tstruct sctp_ulpevent *ev;\n" "> +\n" "> +\t\tev = sctp_ulpevent_make_authkey(asoc, key->key_id,\n" @@ -96,12 +96,12 @@ "> +\t\tstruct sctp_shared_key *shkey = chunk->shkey;\n" "> +\t\tstruct sctp_association *asoc = chunk->asoc;\n" "> +\n" - "> +\t\t/* refcnt = 2 and !list_empty mean after this release, it's\n" + "> +\t\t/* refcnt == 2 and !list_empty mean after this release, it's\n" "> +\t\t * not being used anywhere, and it's time to notify userland\n" "> +\t\t * that this shkey can be freed if it's been deactivated.\n" "> +\t\t */\n" "> +\t\tif (shkey->deactivated && !list_empty(&shkey->key_list) &&\n" - "> +\t\t refcount_read(&shkey->refcnt) = 2) {\n" + "> +\t\t refcount_read(&shkey->refcnt) == 2) {\n" "> +\t\t\tstruct sctp_ulpevent *ev;\n" "> +\n" "> +\t\t\tev = sctp_ulpevent_make_authkey(asoc, shkey->key_id,\n" @@ -140,12 +140,12 @@ "> +\tif (chunk->shkey) {\n" "> +\t\tstruct sctp_shared_key *shkey = chunk->shkey;\n" "> +\n" - "> +\t\t/* refcnt = 2 and !list_empty mean after this release, it's\n" + "> +\t\t/* refcnt == 2 and !list_empty mean after this release, it's\n" "> +\t\t * not being used anywhere, and it's time to notify userland\n" "> +\t\t * that this shkey can be freed if it's been deactivated.\n" "> +\t\t */\n" "> +\t\tif (shkey->deactivated && !list_empty(&shkey->key_list) &&\n" - "> +\t\t refcount_read(&shkey->refcnt) = 2) {\n" + "> +\t\t refcount_read(&shkey->refcnt) == 2) {\n" "> +\t\t\tstruct sctp_ulpevent *ev;\n" "> +\n" "> +\t\t\tev = sctp_ulpevent_make_authkey(asoc, shkey->key_id,\n" @@ -163,4 +163,4 @@ "> 2.1.0\n" > -5e5958593567eaa591c1dba35d5b5b552fb168036c8d15306d09e9705e4abd8e +5d7de7bf50352f71478b8aa82e9d66477d991c973937f0ec275f91ea5a92ffa8
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.