From: Andi Kleen <ak@linux.intel.com>
To: Thomas-Mich Richter <tmricht@linux.vnet.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com
Subject: Re: [PATCH] perf stat: Add support for s390 transaction counters
Date: Wed, 14 Mar 2018 08:43:17 -0700 [thread overview]
Message-ID: <20180314154317.GG13724@tassilo.jf.intel.com> (raw)
In-Reply-To: <a863f62d-e460-639a-b69b-3437b9d4e4c5@linux.vnet.ibm.com>
> S390 has no support for Elision and uses transaction begin/end/abort
> instructions. The CPU measurement counter facility provides counters for
> transaction end and transaction abort.
You don't need to implement the el-* events.
> I have used this table (taken from arch/x86/events/intel/core.c) as giudeline:
> /* Haswell special events */
> EVENT_ATTR_STR(tx-start, tx_start, "event=0xc9,umask=0x1");
> EVENT_ATTR_STR(tx-commit, tx_commit, "event=0xc9,umask=0x2");
> EVENT_ATTR_STR(tx-abort, tx_abort, "event=0xc9,umask=0x4");
> EVENT_ATTR_STR(tx-capacity, tx_capacity, "event=0x54,umask=0x2");
> EVENT_ATTR_STR(tx-conflict, tx_conflict, "event=0x54,umask=0x1");
> EVENT_ATTR_STR(el-start, el_start, "event=0xc8,umask=0x1");
> EVENT_ATTR_STR(el-commit, el_commit, "event=0xc8,umask=0x2");
> EVENT_ATTR_STR(el-abort, el_abort, "event=0xc8,umask=0x4");
> EVENT_ATTR_STR(el-capacity, el_capacity, "event=0x54,umask=0x2");
> EVENT_ATTR_STR(el-conflict, el_conflict, "event=0x54,umask=0x1");
> EVENT_ATTR_STR(cycles-t, cycles_t, "event=0x3c,in_tx=1");
> EVENT_ATTR_STR(cycles-ct, cycles_ct, "event=0x3c,in_tx=1,in_tx_cp=1");
>
>
> So s390 can only support tx_commit and tx-abort symbolic names.
> None of them show up in the transactions_attrs and transaction_limited_attrs
> string variables used in builtin-stat.c file.
We could change perf stat to fall back to only tx commit and tx abort.
We already did that for one limited case.
-Andi
next prev parent reply other threads:[~2018-03-14 15:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 10:38 [PATCH] perf stat: Add support for s390 transaction counters Thomas Richter
2018-03-12 10:38 ` [PATCH] perf stat: Make function perf_stat_evsel_id_init static Thomas Richter
2018-03-12 15:10 ` Arnaldo Carvalho de Melo
2018-03-20 6:29 ` [tip:perf/core] " tip-bot for Thomas Richter
2018-03-12 15:06 ` [PATCH] perf stat: Add support for s390 transaction counters Arnaldo Carvalho de Melo
2018-03-13 3:23 ` Andi Kleen
2018-03-14 8:34 ` Thomas-Mich Richter
2018-03-14 13:18 ` Arnaldo Carvalho de Melo
2018-03-14 15:03 ` Thomas-Mich Richter
2018-03-14 15:43 ` Andi Kleen [this message]
2018-03-14 16:42 ` Hendrik Brueckner
2018-03-14 17:31 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314154317.GG13724@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=brueckner@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=tmricht@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.