From: Borislav Petkov <bp@alien8.de>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/9] x86/microcode/AMD: install_equiv_cpu_table() should not return (signed) int
Date: Wed, 14 Mar 2018 18:58:24 +0100 [thread overview]
Message-ID: <20180314175824.GG16605@pd.tnic> (raw)
In-Reply-To: <cf57ed15-df47-087e-c98f-527e4ce1e0f8@maciej.szmigiero.name>
On Tue, Mar 13, 2018 at 10:06:34PM +0100, Maciej S. Szmigiero wrote:
> The maximum possible value returned by install_equiv_cpu_table() is
> UINT_MAX + CONTAINER_HDR_SZ (on a 64-bit kernel).
> This is more than (signed) int type currently returned by this function can
> hold so this function will need to return a size_t instead.
I'm trying to parse this but I'm not really sure.
All I know is:
unsigned int size = ibuf[2];
and that is really a 4-byte unsigned quantity so anything less is an
arbitrary limitation.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-03-14 17:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1520973389.git.mail@maciej.szmigiero.name>
2018-03-13 21:06 ` [PATCH v3 1/9] x86/microcode/AMD: subtract SECTION_HDR_SIZE from file leftover length Maciej S. Szmigiero
2018-03-14 12:38 ` Borislav Petkov
2018-03-13 21:06 ` [PATCH v3 2/9] x86/microcode/AMD: check whether the equivalence table fits in the file Maciej S. Szmigiero
2018-03-14 17:04 ` Borislav Petkov
2018-03-14 23:34 ` Maciej S. Szmigiero
2018-03-15 10:42 ` Borislav Petkov
2018-03-13 21:06 ` [PATCH v3 3/9] x86/microcode/AMD: install_equiv_cpu_table() should not return (signed) int Maciej S. Szmigiero
2018-03-14 17:58 ` Borislav Petkov [this message]
2018-03-14 23:46 ` Maciej S. Szmigiero
2018-03-14 23:58 ` Borislav Petkov
2018-03-15 0:13 ` Maciej S. Szmigiero
2018-03-15 0:56 ` Borislav Petkov
2018-03-15 0:59 ` Maciej S. Szmigiero
2018-03-13 21:06 ` [PATCH v3 4/9] x86/microcode/AMD: automatically compute the PATCH_MAX_SIZE macro Maciej S. Szmigiero
2018-03-14 18:02 ` Borislav Petkov
2018-03-15 0:05 ` Maciej S. Szmigiero
2018-03-15 1:00 ` Borislav Petkov
2018-03-13 21:06 ` [PATCH v3 5/9] x86/microcode/AMD: check patch size in verify_and_add_patch() Maciej S. Szmigiero
2018-03-13 21:07 ` [PATCH v3 6/9] x86/microcode/AMD: verify patch section type for every such section Maciej S. Szmigiero
2018-03-15 16:31 ` Borislav Petkov
2018-03-13 21:07 ` [PATCH v3 7/9] x86/microcode/AMD: check microcode container file size before accessing it Maciej S. Szmigiero
2018-03-13 21:07 ` [PATCH v3 8/9] x86/microcode/AMD: check the equivalence table size when scanning it Maciej S. Szmigiero
2018-03-13 21:07 ` [PATCH v3 9/9] x86/microcode/AMD: be more tolerant of late parse failures in late loader Maciej S. Szmigiero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314175824.GG16605@pd.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.