From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] soc: imx: gpc: Use kemdup() function
Date: Thu, 15 Mar 2018 11:13:18 +0800 [thread overview]
Message-ID: <20180315031317.GJ26859@dragon> (raw)
In-Reply-To: <1520810382-13341-1-git-send-email-festevam@gmail.com>
Hi Fabio,
On Sun, Mar 11, 2018 at 08:19:42PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Use kmemdup() rather than duplicating its implementation.
>
> Detected with Coccinelle script.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
I copied you on my reply to Andrey Smirnov, in which I requested to
use platform_device_add_data() for his patches. That said, your patches
will be dropped as well.
Shawn
> ---
> drivers/soc/imx/gpc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
> index 196f17b..cc3bad8 100644
> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -444,12 +444,12 @@ static int imx_gpc_probe(struct platform_device *pdev)
> if (domain_index >= of_id_data->num_domains)
> continue;
>
> - domain = kmalloc(sizeof(*domain), GFP_KERNEL);
> + domain = kmemdup(&imx_gpc_domains[domain_index],
> + sizeof(*domain), GFP_KERNEL);
> if (!domain) {
> of_node_put(np);
> return -ENOMEM;
> }
> - memcpy(domain, &imx_gpc_domains[domain_index], sizeof(*domain));
> domain->regmap = regmap;
> domain->ipg_rate_mhz = ipg_rate_mhz;
>
> --
> 2.7.4
>
prev parent reply other threads:[~2018-03-15 3:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-11 23:19 [PATCH] soc: imx: gpc: Use kemdup() function Fabio Estevam
2018-03-15 3:13 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315031317.GJ26859@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.