From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] perf/x86/intel: Add INST_RETIRED.ALL workarounds
Date: Thu, 15 Mar 2018 09:03:46 +0000 [thread overview]
Message-ID: <20180315090346.GA23080@mwanda> (raw)
Hello Andi Kleen,
The patch 294fe0f52a44: "perf/x86/intel: Add INST_RETIRED.ALL
workarounds" from Feb 17, 2015, leads to the following static checker
warning:
arch/x86/events/intel/core.c:3213 bdw_limit_period()
warn: was expecting a 64 bit value instead of '63'
arch/x86/events/intel/core.c
3207 static u64 bdw_limit_period(struct perf_event *event, u64 left)
^^^^^^^^
3208 {
3209 if ((event->hw.config & INTEL_ARCH_EVENT_MASK) =
3210 X86_CONFIG(.event=0xc0, .umask=0x01)) {
3211 if (left < 128)
3212 left = 128;
3213 left &= ~0x3fu;
^^^^^^^^^^^^^^
You're clearing the high 32 bits as well as the low 6. It should be
~0x3full.
3214 }
3215 return left;
3216 }
regards,
dan carpenter
next reply other threads:[~2018-03-15 9:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 9:03 Dan Carpenter [this message]
2018-03-15 9:30 ` [bug report] perf/x86/intel: Add INST_RETIRED.ALL workarounds Walter Harms
2018-03-16 14:54 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315090346.GA23080@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.