From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,1/2] drivers/edac: Add L1 and L2 error detection for A53 and A57 From: Borislav Petkov Message-Id: <20180315101725.GC27816@pd.tnic> Date: Thu, 15 Mar 2018 11:17:25 +0100 To: York Sun Cc: "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , James Morse List-ID: T24gVGh1LCBNYXIgMTUsIDIwMTggYXQgMDE6MjA6MThBTSArMDAwMCwgWW9yayBTdW4gd3JvdGU6 Cj4gVGhlIGRpc2N1c3Npb24gbGVkIHRvIHVzaW5nIGRldmljZSB0cmVlIHRvIHNwZWNpZnkgd2hp Y2ggY29yZXMgaGF2ZSB0aGlzCj4gZmVhdHVyZS4gU2luY2UgdGhpcyBmZWF0dXJlIGlzICJpbXBs ZW1lbnRhdGlvbiBkZXBlbmRlbnQiLCBJIGNhbiBvbmx5Cj4gY29uZmlybSBpdCBpcyBhdmFpbGFi bGUgb24gQTUzIGNvcmUsIGFuZCBwYXJ0aWFsbHkgb24gQTU3IGNvcmUgKGxhY2tpbmcKPiBlcnJv ciBpbmplY3Rpb24pLiBJdCBpcyBub3QgZ2VuZXJpYyB0byBBUk02NCBjb3Jlcy4KClNvIG15IEFS TSBwZXJzb24gaXMgdGVsbGluZyBtZSBBNTMgaXMgbGl0dGxlIGFuZCBBNTcgaXMgYmlnLgoKSW4g YW55IGNhc2UsIEknZCBsaWtlIHRvIGhhdmUgYSBzYW5lIGNvbGxlY3Rpb24gb2YgUkFTIGZ1bmN0 aW9uYWxpdHksCmVpdGhlciBwZXIgdWFyY2ggb3IgcGVyIHZlbmRvci4gU28gSSBjYW4gaW1hZ2lu ZSBoYXZpbmcgZWRhY19hNTMsCmVkYWNfYTU3LCBldGMuCgpCdXQgbm90IHBlciBmdW5jdGlvbmFs IHVuaXQuIEVzcGVjaWFsbHkgaWYgdGhlIGZ1bmN0aW9uYWxpdHkgaXMgc2hhcmVkCmJldHdlZW4g Y29yZSBkZXNpZ25zLgoKSW4gdGhhdCBjYXNlLCB3ZSdsbCBoYXZlIHRvIGRvIHNvbWV0aGluZyBs aWtlIGZzbF9kZHJfZWRhYyBiZWluZyBzaGFyZWQKYmV0d2VlbiBNUEM4NXh4IGFuZCBsYXllcnNj YXBlLgoKPiBXZSBjYW4gbGVhdmUgdGhpcyBwYXRjaCBmbG9hdGluZy4gSWYgc29tZW9uZSBlbHNl IGZpbmRzIGl0IHVzZWZ1bCwgd2UKPiBjYW4gcmVzdW1lIHRoZSBkaXNjdXNzaW9uIG9uIGhvdyB0 byBnZW5lcmFsaXplIGl0LgoKWWVzLiBJZiB5b3Ugd2FudCB0byBkbyBhIG54cF9lZGFjIG9yIHNv IHdoaWNoIHN1cHBvcnRzIHlvdXIgaGFyZHdhcmUsCnRoYXQncyBmaW5lLiBBbmQgdGhlbiBoYXZl IHRoZSBkaWZmZXJlbnQgZnVuY3Rpb25hbCB1bml0cyBnZXQgYnVpbHQgaW50bwphIGZpbmFsIGVk YWMgZHJpdmVyLCB0aGF0J3MgZmluZSB3aXRoIG1lIHRvby4gT3RoZXIgZHJpdmVycyB3aWxsIHJl dXNlCnRob3NlIGZ1bmN0aW9uYWwgdW5pdHMgc2luY2UgdGhleSdyZSBzdG9jayBhbmQgc2hvdWxk IGFkaGVyZSB0byB0aGUKZGVzaWduLi4uCgpUaHguCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751588AbeCOKSI (ORCPT ); Thu, 15 Mar 2018 06:18:08 -0400 Received: from mail.skyhub.de ([5.9.137.197]:60562 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbeCOKSG (ORCPT ); Thu, 15 Mar 2018 06:18:06 -0400 Date: Thu, 15 Mar 2018 11:17:25 +0100 From: Borislav Petkov To: York Sun Cc: "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , James Morse Subject: Re: [PATCH RFC 1/2] drivers/edac: Add L1 and L2 error detection for A53 and A57 Message-ID: <20180315101725.GC27816@pd.tnic> References: <1521073067-24348-1-git-send-email-york.sun@nxp.com> <20180315010728.GF11061@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 15, 2018 at 01:20:18AM +0000, York Sun wrote: > The discussion led to using device tree to specify which cores have this > feature. Since this feature is "implementation dependent", I can only > confirm it is available on A53 core, and partially on A57 core (lacking > error injection). It is not generic to ARM64 cores. So my ARM person is telling me A53 is little and A57 is big. In any case, I'd like to have a sane collection of RAS functionality, either per uarch or per vendor. So I can imagine having edac_a53, edac_a57, etc. But not per functional unit. Especially if the functionality is shared between core designs. In that case, we'll have to do something like fsl_ddr_edac being shared between MPC85xx and layerscape. > We can leave this patch floating. If someone else finds it useful, we > can resume the discussion on how to generalize it. Yes. If you want to do a nxp_edac or so which supports your hardware, that's fine. And then have the different functional units get built into a final edac driver, that's fine with me too. Other drivers will reuse those functional units since they're stock and should adhere to the design... Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.