From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [bug report] drm/i915: Eliminate lots of iterations over the execobjects array Date: Thu, 15 Mar 2018 16:10:30 +0300 Message-ID: <20180315131030.GA23041@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by gabe.freedesktop.org (Postfix) with ESMTPS id 835006E3F2 for ; Thu, 15 Mar 2018 13:10:47 +0000 (UTC) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: chris@chris-wilson.co.uk Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGVsbG8gQ2hyaXMgV2lsc29uLAoKVGhlIHBhdGNoIDI4ODljYWE5MjMyMTogImRybS9pOTE1OiBF bGltaW5hdGUgbG90cyBvZiBpdGVyYXRpb25zIG92ZXIKdGhlIGV4ZWNvYmplY3RzIGFycmF5IiBm cm9tIEp1biAxNiwgMjAxNywgbGVhZHMgdG8gdGhlIGZvbGxvd2luZwpzdGF0aWMgY2hlY2tlciB3 YXJuaW5nOgoKCWRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYzoyNTQ2 IGk5MTVfZ2VtX2V4ZWNidWZmZXJfaW9jdGwoKQoJd2FybjogY2FsbGluZyAnX19jb3B5X3RvX3Vz ZXIoKScgd2l0aG91dCBhY2Nlc3Nfb2soKQoKZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1f ZXhlY2J1ZmZlci5jCiAgMjUxMCAgICAgICAgICBlcnIgPSBjb3B5X2Zyb21fdXNlcihleGVjX2xp c3QsCiAgMjUxMSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1NjRfdG9fdXNlcl9wdHIo YXJncy0+YnVmZmVyc19wdHIpLAogIDI1MTIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg c2l6ZW9mKCpleGVjX2xpc3QpICogY291bnQpOwogIDI1MTMgICAgICAgICAgaWYgKGVycikgewog IDI1MTQgICAgICAgICAgICAgICAgICBEUk1fREVCVUcoImNvcHkgJWQgZXhlYyBlbnRyaWVzIGZh aWxlZCAlZFxuIiwKICAyNTE1ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFyZ3MtPmJ1ZmZl cl9jb3VudCwgZXJyKTsKICAyNTE2ICAgICAgICAgICAgICAgICAga3ZmcmVlKGV4ZWNfbGlzdCk7 CiAgMjUxNyAgICAgICAgICAgICAgICAgIGt2ZnJlZShleGVjMl9saXN0KTsKICAyNTE4ICAgICAg ICAgICAgICAgICAgcmV0dXJuIC1FRkFVTFQ7CiAgMjUxOSAgICAgICAgICB9CiAgMjUyMCAgCiAg MjUyMSAgICAgICAgICBmb3IgKGkgPSAwOyBpIDwgYXJncy0+YnVmZmVyX2NvdW50OyBpKyspIHsK ICAyNTIyICAgICAgICAgICAgICAgICAgZXhlYzJfbGlzdFtpXS5oYW5kbGUgPSBleGVjX2xpc3Rb aV0uaGFuZGxlOwogIDI1MjMgICAgICAgICAgICAgICAgICBleGVjMl9saXN0W2ldLnJlbG9jYXRp b25fY291bnQgPSBleGVjX2xpc3RbaV0ucmVsb2NhdGlvbl9jb3VudDsKICAyNTI0ICAgICAgICAg ICAgICAgICAgZXhlYzJfbGlzdFtpXS5yZWxvY3NfcHRyID0gZXhlY19saXN0W2ldLnJlbG9jc19w dHI7CiAgMjUyNSAgICAgICAgICAgICAgICAgIGV4ZWMyX2xpc3RbaV0uYWxpZ25tZW50ID0gZXhl Y19saXN0W2ldLmFsaWdubWVudDsKICAyNTI2ICAgICAgICAgICAgICAgICAgZXhlYzJfbGlzdFtp XS5vZmZzZXQgPSBleGVjX2xpc3RbaV0ub2Zmc2V0OwogIDI1MjcgICAgICAgICAgICAgICAgICBp ZiAoSU5URUxfR0VOKHRvX2k5MTUoZGV2KSkgPCA0KQogIDI1MjggICAgICAgICAgICAgICAgICAg ICAgICAgIGV4ZWMyX2xpc3RbaV0uZmxhZ3MgPSBFWEVDX09CSkVDVF9ORUVEU19GRU5DRTsKICAy NTI5ICAgICAgICAgICAgICAgICAgZWxzZQogIDI1MzAgICAgICAgICAgICAgICAgICAgICAgICAg IGV4ZWMyX2xpc3RbaV0uZmxhZ3MgPSAwOwogIDI1MzEgICAgICAgICAgfQogIDI1MzIgIAogIDI1 MzMgICAgICAgICAgZXJyID0gaTkxNV9nZW1fZG9fZXhlY2J1ZmZlcihkZXYsIGZpbGUsICZleGVj MiwgZXhlYzJfbGlzdCwgTlVMTCk7CiAgMjUzNCAgICAgICAgICBpZiAoZXhlYzIuZmxhZ3MgJiBf X0VYRUNfSEFTX1JFTE9DKSB7CiAgMjUzNSAgICAgICAgICAgICAgICAgIHN0cnVjdCBkcm1faTkx NV9nZW1fZXhlY19vYmplY3QgX191c2VyICp1c2VyX2V4ZWNfbGlzdCA9CiAgMjUzNiAgICAgICAg ICAgICAgICAgICAgICAgICAgdTY0X3RvX3VzZXJfcHRyKGFyZ3MtPmJ1ZmZlcnNfcHRyKTsKICAy NTM3ICAKICAyNTM4ICAgICAgICAgICAgICAgICAgLyogQ29weSB0aGUgbmV3IGJ1ZmZlciBvZmZz ZXRzIGJhY2sgdG8gdGhlIHVzZXIncyBleGVjIGxpc3QuICovCiAgMjUzOSAgICAgICAgICAgICAg ICAgIGZvciAoaSA9IDA7IGkgPCBhcmdzLT5idWZmZXJfY291bnQ7IGkrKykgewogIDI1NDAgICAg ICAgICAgICAgICAgICAgICAgICAgIGlmICghKGV4ZWMyX2xpc3RbaV0ub2Zmc2V0ICYgVVBEQVRF KSkKICAyNTQxICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogIDI1 NDIgIAogIDI1NDMgICAgICAgICAgICAgICAgICAgICAgICAgIGV4ZWMyX2xpc3RbaV0ub2Zmc2V0 ID0KICAyNTQ0ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdlbjhfY2Fub25pY2Fs X2FkZHIoZXhlYzJfbGlzdFtpXS5vZmZzZXQgJiBQSU5fT0ZGU0VUX01BU0spOwogIDI1NDUgICAg ICAgICAgICAgICAgICAgICAgICAgIGV4ZWMyX2xpc3RbaV0ub2Zmc2V0ICY9IFBJTl9PRkZTRVRf TUFTSzsKICAyNTQ2ICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoX19jb3B5X3RvX3VzZXIo JnVzZXJfZXhlY19saXN0W2ldLm9mZnNldCwKICAyNTQ3ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgJmV4ZWMyX2xpc3RbaV0ub2Zmc2V0LAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXl5eXl5eXl5eXl5eXl5eXl5e Xl4KICAyNTQ4ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2l6 ZW9mKHVzZXJfZXhlY19saXN0W2ldLm9mZnNldCkpKQogIDI1NDkgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgYnJlYWs7CgpUaGUgc3Rvcnkgb2YgdGhpcyB3YXJuaW5nIGlzIHRoYXQg b25lIGRheSBMaW51cyB3YXMgZ3J1bXB5IGFib3V0CnNlY3VyaXR5IGlzc3VlcyBhbmQgc2FpZCBz b21ldGhpbmcgbGlrZSwgIldlIHNob3VsZCBtYWtlIGl0IGEgcnVsZSB0aGF0CmNvZGUgd2hpY2gg dXNlcyBfX2NvcHlfdG9fdXNlcigpIHNob3VsZCBjYWxsIGFjY2Vzc19vaygpIGluIHRoYXQgZXhh Y3QKc2FtZSBmdW5jdGlvbiBvciBpdCBiZWNvbWVzIHRvbyBoYXJkIHRvIGF1ZGl0IGFuZCBlcnJv ciBwcm9uZS4gIENhbgpzb21lb25lIHdyaXRlIGEgc3RhdGljIGNoZWNrZXIgZm9yIHRoaXM/IiAg QW5kIHNvIEkgZGlkLiAgQnV0IHVwIHRvIG5vdwpJJ3ZlIGFsd2F5cyBqdXN0IGxvb2tlZCBhdCB0 aGUgY29kZSBhbmQgZWl0aGVyIGZpZ3VyZWQgb3V0IHdoZXJlIHRoZQphY2Nlc3Nfb2soKSBpcyBv ciBqdXN0IGFzc3VtZWQgdGhhdCAiUHJvYmFibHkgaXQncyB0aGVyZSBpZiBJIGxvb2tlZApoYXJk ZXIiLgoKQnV0IHRvZGF5IEkndmUgZHJhd24gYSBsaW5lIGluIHRoZSBzYW5kISAgTm8gbW9yZSEK CkFsc28gdGhlIGVycm9yIGNvZGUgaXMgd3JvbmcsIHdlIHNob3VsZCByZXR1cm4gLUVGQVVMVCBp ZiB0aGUgY29weQpmYWlscy4gIDspCgogIDI1NTAgICAgICAgICAgICAgICAgICB9CiAgMjU1MSAg ICAgICAgICB9CiAgMjU1MiAgCiAgMjU1MyAgICAgICAgICBrdmZyZWUoZXhlY19saXN0KTsKCnJl Z2FyZHMsCmRhbiBjYXJwZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==